From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C59F63975 for ; Mon, 17 Nov 2014 17:42:36 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 17 Nov 2014 08:46:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="417659023" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.33]) by FMSMGA003.fm.intel.com with SMTP; 17 Nov 2014 08:43:34 -0800 Received: by (sSMTP sendmail emulation); Mon, 17 Nov 2014 16:52:50 +0025 Date: Mon, 17 Nov 2014 16:52:50 +0000 From: Bruce Richardson To: Nicolas Pernas Maradei Message-ID: <20141117165249.GA6860@bricha3-MOBL3> References: <1416173215-27533-1-git-send-email-nicolas.pernas.maradei@emutex.com> <20141117141050.GD17886@hmsreliant.think-freely.org> <546A0BA2.3040306@emutex.com> <20141117160041.GF17886@hmsreliant.think-freely.org> <546A24F3.4080107@emutex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <546A24F3.4080107@emutex.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, Nicolas Pernas Maradei Subject: Re: [dpdk-dev] [PATCH] eal: allow virtual devices to be white/black listed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2014 16:42:37 -0000 On Mon, Nov 17, 2014 at 04:40:19PM +0000, Nicolas Pernas Maradei wrote: > > On 17/11/14 16:00, Neil Horman wrote: > >I get that, I was more asking, why those values? They seem a bit magic to me, > >and might benefit from some descriptive macros or comments so they make more > >sense > >Neil > OK, I get you now. > > Maybe the diff is not very clear. I just left the original calls to > rte_eal_devargs_add() with the original values which they looked clear to me > but I don't mind improving the comments a bit and as you suggested, adding > in some macros. > > I'll wait for some more feedback before submitting a second version of the > patch. > Those are just example values for testing the parsing functionality. I'm don't think descriptive macros are particularly needed, though maybe a short comment or two might help out. The specific numeric values themselves aren't really important, they are just examples of different patterns. /Bruce