From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id F287C595B
 for <dev@dpdk.org>; Mon, 17 Nov 2014 22:06:59 +0100 (CET)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1XqTfc-0007DW-6r; Mon, 17 Nov 2014 16:17:14 -0500
Date: Mon, 17 Nov 2014 16:17:11 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Message-ID: <20141117211711.GH17886@hmsreliant.think-freely.org>
References: <1416173215-27533-1-git-send-email-nicolas.pernas.maradei@emutex.com>
 <20141117141050.GD17886@hmsreliant.think-freely.org>
 <546A0BA2.3040306@emutex.com>
 <20141117160041.GF17886@hmsreliant.think-freely.org>
 <546A24F3.4080107@emutex.com> <20141117165249.GA6860@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141117165249.GA6860@bricha3-MOBL3>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org, Nicolas Pernas Maradei <nicolas.pernas.maradei@emutex.com>,
 Nicolas Pernas Maradei <nico@emutex.com>
Subject: Re: [dpdk-dev] [PATCH] eal: allow virtual devices to be white/black
 listed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Nov 2014 21:07:00 -0000

On Mon, Nov 17, 2014 at 04:52:50PM +0000, Bruce Richardson wrote:
> On Mon, Nov 17, 2014 at 04:40:19PM +0000, Nicolas Pernas Maradei wrote:
> > 
> > On 17/11/14 16:00, Neil Horman wrote:
> > >I get that, I was more asking, why those values?  They seem a bit magic to me,
> > >and might benefit from some descriptive macros or comments so they make more
> > >sense
> > >Neil
> > OK, I get you now.
> > 
> > Maybe the diff is not very clear. I just left the original calls to
> > rte_eal_devargs_add() with the original values which they looked clear to me
> > but I don't mind improving the comments a bit and as you suggested, adding
> > in some macros.
> > 
> > I'll wait for some more feedback before submitting a second version of the
> > patch.
> >
> 
> Those are just example values for testing the parsing functionality. I'm don't
> think descriptive macros are particularly needed, though maybe a short comment
> or two might help out. The specific numeric values themselves aren't really important,
> they are just examples of different patterns.
> 
> /Bruce
> 
> 

Agreed, if they're just arbitrary bus/dev/func values, Marcos aren't needed,
just a comment calling them out as such.

Thanks!
Neil