From: Neil Horman <nhorman@tuxdriver.com>
To: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/6] ENIC PMD Makefile
Date: Fri, 21 Nov 2014 15:21:56 -0500 [thread overview]
Message-ID: <20141121202156.GG20661@hmsreliant.think-freely.org> (raw)
In-Reply-To: <D0955934.284E5%ssujith@cisco.com>
On Fri, Nov 21, 2014 at 03:35:31PM +0000, Sujith Sankar (ssujith) wrote:
>
>
> On 21/11/14 5:03 pm, "Neil Horman" <nhorman@tuxdriver.com> wrote:
>
> >On Fri, Nov 21, 2014 at 10:02:59PM +0530, Sujith Sankar wrote:
> >> Signed-off-by: Sujith Sankar <ssujith@cisco.com>
> >> ---
> >> lib/librte_pmd_enic/Makefile | 67
> >>++++++++++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 67 insertions(+)
> >> create mode 100644 lib/librte_pmd_enic/Makefile
> >>
> >> diff --git a/lib/librte_pmd_enic/Makefile b/lib/librte_pmd_enic/Makefile
> >> new file mode 100644
> >> index 0000000..2073cd6
> >> --- /dev/null
> >> +++ b/lib/librte_pmd_enic/Makefile
> >> @@ -0,0 +1,67 @@
> >> +# BSD LICENSE
> >> +#
> >> +# Copyright(c) 2010-2013 Intel Corporation. All rights reserved.
> >> +# All rights reserved.
> >> +#
> >This should be (c) Cisco, shouldn't it?
> This file was taken from DPDK source and modified. Hence I thought I
> should be retaining the copyright.
> Please let me know if this is not right.
Given that you've modified it to build ENIC, I would say change the copyright
Neil
> >
> >> +# Redistribution and use in source and binary forms, with or without
> >> +# modification, are permitted provided that the following conditions
> >> +# are met:
> >> +#
> >> +# * Redistributions of source code must retain the above copyright
> >> +# notice, this list of conditions and the following disclaimer.
> >> +# * Redistributions in binary form must reproduce the above
> >>copyright
> >> +# notice, this list of conditions and the following disclaimer
> >>in
> >> +# the documentation and/or other materials provided with the
> >> +# distribution.
> >> +# * Neither the name of Intel Corporation nor the names of its
> >> +# contributors may be used to endorse or promote products
> >>derived
> >> +# from this software without specific prior written permission.
> >> +#
> >> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> >>CONTRIBUTORS
> >> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> >> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> >>FOR
> >> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> >>COPYRIGHT
> >> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> >>INCIDENTAL,
> >> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> >> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
> >>USE,
> >> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
> >>ANY
> >> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
> >>TORT
> >> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
> >>USE
> >> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> >>DAMAGE.
> >> +#
> >> +
> >> +include $(RTE_SDK)/mk/rte.vars.mk
> >> +
> >> +#
> >> +# library name
> >> +#
> >> +LIB = librte_pmd_enic.a
> >> +
> >> +CFLAGS += -I$(RTE_SDK)/lib/librte_hash/
> >>-I$(RTE_SDK)/lib/librte_pmd_enic/
> >> +CFLAGS += -I$(RTE_SDK)/lib/librte_pmd_enic/vnic/
> >> +CFLAGS += -O3 -Wno-deprecated
> >> +
> >> +VPATH += $(RTE_SDK)/lib/librte_pmd_enic/src
> >> +
> >> +#
> >> +# all source are stored in SRCS-y
> >> +#
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic_main.c
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic_clsf.c
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_cq.c
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_wq.c
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_dev.c
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_intr.c
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_rq.c
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic_etherdev.c
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic_res.c
> >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_rss.c
> >> +
> >> +
> >> +# this lib depends upon:
> >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += lib/librte_eal
> >>lib/librte_ether
> >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += lib/librte_mempool
> >>lib/librte_mbuf
> >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += lib/librte_net
> >>lib/librte_malloc
> >> +
> >> +include $(RTE_SDK)/mk/rte.lib.mk
> >> +
> >> --
> >> 1.9.1
> >>
> >>
>
>
next prev parent reply other threads:[~2014-11-21 20:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 16:32 [dpdk-dev] [PATCH v2 0/6] Cisco Systems Inc. VIC Ethernet PMD - ENIC PMD Sujith Sankar
2014-11-21 9:52 ` David Marchand
2014-11-21 9:58 ` Sujith Sankar (ssujith)
2014-11-21 10:05 ` David Marchand
2014-11-21 16:32 ` [dpdk-dev] [PATCH v2 1/6] ENIC PMD License Sujith Sankar
2014-11-21 16:32 ` [dpdk-dev] [PATCH v2 2/6] ENIC PMD Makefile Sujith Sankar
2014-11-21 11:33 ` Neil Horman
2014-11-21 15:35 ` Sujith Sankar (ssujith)
2014-11-21 20:21 ` Neil Horman [this message]
2014-11-21 16:33 ` [dpdk-dev] [PATCH v2 3/6] VNIC common code partially shared with ENIC kernel mode driver Sujith Sankar
2014-11-21 16:33 ` [dpdk-dev] [PATCH v2 4/6] ENIC PMD specific code Sujith Sankar
2014-11-21 16:33 ` [dpdk-dev] [PATCH v2 5/6] DPDK-ENIC PMD interface Sujith Sankar
2014-11-21 13:24 ` Neil Horman
2014-11-21 15:36 ` Sujith Sankar (ssujith)
2014-11-21 16:33 ` [dpdk-dev] [PATCH v2 6/6] DPDK changes for accommodating ENIC PMD Sujith Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121202156.GG20661@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).