From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id D05FD7F50 for ; Fri, 21 Nov 2014 21:11:24 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1XruiL-0006sy-6E; Fri, 21 Nov 2014 15:21:59 -0500 Date: Fri, 21 Nov 2014 15:21:56 -0500 From: Neil Horman To: "Sujith Sankar (ssujith)" Message-ID: <20141121202156.GG20661@hmsreliant.think-freely.org> References: <1416587583-2021-1-git-send-email-ssujith@cisco.com> <1416587583-2021-3-git-send-email-ssujith@cisco.com> <20141121113317.GB20661@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 2/6] ENIC PMD Makefile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2014 20:11:25 -0000 On Fri, Nov 21, 2014 at 03:35:31PM +0000, Sujith Sankar (ssujith) wrote: > > > On 21/11/14 5:03 pm, "Neil Horman" wrote: > > >On Fri, Nov 21, 2014 at 10:02:59PM +0530, Sujith Sankar wrote: > >> Signed-off-by: Sujith Sankar > >> --- > >> lib/librte_pmd_enic/Makefile | 67 > >>++++++++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 67 insertions(+) > >> create mode 100644 lib/librte_pmd_enic/Makefile > >> > >> diff --git a/lib/librte_pmd_enic/Makefile b/lib/librte_pmd_enic/Makefile > >> new file mode 100644 > >> index 0000000..2073cd6 > >> --- /dev/null > >> +++ b/lib/librte_pmd_enic/Makefile > >> @@ -0,0 +1,67 @@ > >> +# BSD LICENSE > >> +# > >> +# Copyright(c) 2010-2013 Intel Corporation. All rights reserved. > >> +# All rights reserved. > >> +# > >This should be (c) Cisco, shouldn't it? > This file was taken from DPDK source and modified. Hence I thought I > should be retaining the copyright. > Please let me know if this is not right. Given that you've modified it to build ENIC, I would say change the copyright Neil > > > >> +# Redistribution and use in source and binary forms, with or without > >> +# modification, are permitted provided that the following conditions > >> +# are met: > >> +# > >> +# * Redistributions of source code must retain the above copyright > >> +# notice, this list of conditions and the following disclaimer. > >> +# * Redistributions in binary form must reproduce the above > >>copyright > >> +# notice, this list of conditions and the following disclaimer > >>in > >> +# the documentation and/or other materials provided with the > >> +# distribution. > >> +# * Neither the name of Intel Corporation nor the names of its > >> +# contributors may be used to endorse or promote products > >>derived > >> +# from this software without specific prior written permission. > >> +# > >> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > >>CONTRIBUTORS > >> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > >> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS > >>FOR > >> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > >>COPYRIGHT > >> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, > >>INCIDENTAL, > >> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > >> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF > >>USE, > >> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON > >>ANY > >> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR > >>TORT > >> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE > >>USE > >> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > >>DAMAGE. > >> +# > >> + > >> +include $(RTE_SDK)/mk/rte.vars.mk > >> + > >> +# > >> +# library name > >> +# > >> +LIB = librte_pmd_enic.a > >> + > >> +CFLAGS += -I$(RTE_SDK)/lib/librte_hash/ > >>-I$(RTE_SDK)/lib/librte_pmd_enic/ > >> +CFLAGS += -I$(RTE_SDK)/lib/librte_pmd_enic/vnic/ > >> +CFLAGS += -O3 -Wno-deprecated > >> + > >> +VPATH += $(RTE_SDK)/lib/librte_pmd_enic/src > >> + > >> +# > >> +# all source are stored in SRCS-y > >> +# > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic_main.c > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic_clsf.c > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_cq.c > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_wq.c > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_dev.c > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_intr.c > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_rq.c > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic_etherdev.c > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic_res.c > >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += vnic/vnic_rss.c > >> + > >> + > >> +# this lib depends upon: > >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += lib/librte_eal > >>lib/librte_ether > >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += lib/librte_mempool > >>lib/librte_mbuf > >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += lib/librte_net > >>lib/librte_malloc > >> + > >> +include $(RTE_SDK)/mk/rte.lib.mk > >> + > >> -- > >> 1.9.1 > >> > >> > >