DPDK patches and discussions
 help / color / mirror / Atom feed
From: chaozhu@linux.vnet.ibm.com
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix remaining checks for other 64bits architectures
Date: Mon, 24 Nov 2014 10:58:11 -0500	[thread overview]
Message-ID: <20141124105811.Horde.yzi-ZleYQoe06Ldh-qmKsQ6@ltc.linux.ibm.com> (raw)
In-Reply-To: <1416842331-7716-1-git-send-email-david.marchand@6wind.com>


Quoting David Marchand <david.marchand@6wind.com>:

> RTE_ARCH_X86_64 can not be used as a way to determine if we are building for
> 64bits cpus. Instead, RTE_ARCH_64 should be used.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  lib/librte_eal/linuxapp/eal/eal.c               |    2 +-
>  lib/librte_eal/linuxapp/eal/eal_hugepage_info.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c  
> b/lib/librte_eal/linuxapp/eal/eal.c
> index f9517c7..e321524 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -450,7 +450,7 @@ eal_parse_base_virtaddr(const char *arg)
>  		return -1;
>
>  	/* make sure we don't exceed 32-bit boundary on 32-bit target */
> -#ifndef RTE_ARCH_X86_64
> +#ifndef RTE_ARCH_64
>  	if (addr >= UINTPTR_MAX)
>  		return -1;
>  #endif
> diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c  
> b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> index 73d1cdb..590cb56 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> @@ -324,7 +324,7 @@ eal_hugepage_info_init(void)
>  				 * later they will be sorted */
>  				hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
>
> -#ifndef RTE_ARCH_X86_64
> +#ifndef RTE_ARCH_64
>  				/* for 32-bit systems, limit number of hugepages to 1GB per page size */
>  				hpi->num_pages[0] = RTE_MIN(hpi->num_pages[0],
>  						RTE_PGSIZE_1G / hpi->hugepage_sz);
> --
> 1.7.10.4
Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>

  reply	other threads:[~2014-11-24 15:47 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24  1:22 [dpdk-dev] [PATCH v3 00/14] Patches for DPDK to support Power architecture Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 01/14] Add compiling definations for IBM " Chao Zhu
2014-11-23 22:02   ` Neil Horman
2014-11-25  3:51     ` Chao Zhu
2014-11-25  8:44       ` Bruce Richardson
2014-11-25  9:19         ` Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 02/14] Add atomic operations " Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 03/14] Add byte order " Chao Zhu
2014-11-24  8:11   ` Qiu, Michael
2014-11-26  2:35     ` Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 04/14] Add CPU cycle " Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 05/14] Add prefetch operation " Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 06/14] Add spinlock " Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 07/14] Add vector memcpy " Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 08/14] Add CPU flag checking " Chao Zhu
2014-11-24 14:14   ` Neil Horman
2014-11-25  3:27     ` Chao Zhu
2014-11-25 11:37       ` Neil Horman
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 09/14] Remove iopl operation " Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 10/14] Add cache size define for IBM Power Architecture Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 11/14] Add huge page size define for IBM Power architecture Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 12/14] Add eal memory support for IBM Power Architecture Chao Zhu
2014-11-24 15:17   ` David Marchand
2014-11-24 15:18     ` [dpdk-dev] [PATCH] eal: fix remaining checks for other 64bits architectures David Marchand
2014-11-24 15:58       ` chaozhu [this message]
2014-11-27  7:47         ` Thomas Monjalon
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 13/14] test_memzone:fix finding the second smallest segment Chao Zhu
2014-11-24  1:22 ` [dpdk-dev] [PATCH v3 14/14] Fix the compiling of test-pmd on IBM Power Architecture Chao Zhu
2014-11-24 15:05 ` [dpdk-dev] [PATCH v3 00/14] Patches for DPDK to support Power architecture David Marchand
2014-11-24 15:49   ` chaozhu
2014-11-25  2:49   ` Chao Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141124105811.Horde.yzi-ZleYQoe06Ldh-qmKsQ6@ltc.linux.ibm.com \
    --to=chaozhu@linux.vnet.ibm.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).