From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e9.ny.us.ibm.com (e9.ny.us.ibm.com [32.97.182.139]) by dpdk.org (Postfix) with ESMTP id EB668804F for ; Mon, 24 Nov 2014 16:47:26 +0100 (CET) Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Nov 2014 10:58:14 -0500 Received: from d01dlp02.pok.ibm.com (9.56.250.167) by e9.ny.us.ibm.com (192.168.1.109) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 24 Nov 2014 10:58:12 -0500 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 45B076E8045 for ; Mon, 24 Nov 2014 10:50:07 -0500 (EST) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sAOFwC6k24445040 for ; Mon, 24 Nov 2014 15:58:12 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sAOFwBit031269 for ; Mon, 24 Nov 2014 10:58:11 -0500 Received: from ltcweb.rtp.raleigh.ibm.com (ltcweb.rtp.raleigh.ibm.com [9.37.210.204]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id sAOFwBFg031234; Mon, 24 Nov 2014 10:58:11 -0500 Received: by ltcweb.rtp.raleigh.ibm.com (Postfix, from userid 48) id 5B8BBC0D8E; Mon, 24 Nov 2014 10:58:11 -0500 (EST) Received: from 9.77.176.102 ([9.77.176.102]) by ltc.linux.ibm.com (Horde Framework) with HTTP; Mon, 24 Nov 2014 10:58:11 -0500 Date: Mon, 24 Nov 2014 10:58:11 -0500 Message-ID: <20141124105811.Horde.yzi-ZleYQoe06Ldh-qmKsQ6@ltc.linux.ibm.com> From: chaozhu@linux.vnet.ibm.com To: David Marchand References: <1416842331-7716-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1416842331-7716-1-git-send-email-david.marchand@6wind.com> User-Agent: Internet Messaging Program (IMP) H5 (6.1.7) Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14112415-0033-0000-0000-00000122BF9A Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: fix remaining checks for other 64bits architectures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Nov 2014 15:47:27 -0000 Quoting David Marchand : > RTE_ARCH_X86_64 can not be used as a way to determine if we are building for > 64bits cpus. Instead, RTE_ARCH_64 should be used. > > Signed-off-by: David Marchand > --- > lib/librte_eal/linuxapp/eal/eal.c | 2 +- > lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c > b/lib/librte_eal/linuxapp/eal/eal.c > index f9517c7..e321524 100644 > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -450,7 +450,7 @@ eal_parse_base_virtaddr(const char *arg) > return -1; > > /* make sure we don't exceed 32-bit boundary on 32-bit target */ > -#ifndef RTE_ARCH_X86_64 > +#ifndef RTE_ARCH_64 > if (addr >= UINTPTR_MAX) > return -1; > #endif > diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > index 73d1cdb..590cb56 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > +++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > @@ -324,7 +324,7 @@ eal_hugepage_info_init(void) > * later they will be sorted */ > hpi->num_pages[0] = get_num_hugepages(dirent->d_name); > > -#ifndef RTE_ARCH_X86_64 > +#ifndef RTE_ARCH_64 > /* for 32-bit systems, limit number of hugepages to 1GB per page size */ > hpi->num_pages[0] = RTE_MIN(hpi->num_pages[0], > RTE_PGSIZE_1G / hpi->hugepage_sz); > -- > 1.7.10.4 Acked-by: Chao Zhu