DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ethdev: fix doxygen comments about RSS
@ 2014-11-24 22:09 Thomas Monjalon
  2014-11-25  8:47 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2014-11-24 22:09 UTC (permalink / raw)
  To: dev

The parameters port_id didn't match with comments about port.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 lib/librte_ether/rte_ethdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index fec4d4c..78a9d37 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -3370,7 +3370,7 @@ int rte_eth_dev_bypass_wd_reset(uint8_t port);
  /**
  * Configuration of Receive Side Scaling hash computation of Ethernet device.
  *
- * @param port
+ * @param port_id
  *   The port identifier of the Ethernet device.
  * @param rss_conf
  *   The new configuration to use for RSS hash computation on the port.
@@ -3387,7 +3387,7 @@ int rte_eth_dev_rss_hash_update(uint8_t port_id,
  * Retrieve current configuration of Receive Side Scaling hash computation
  * of Ethernet device.
  *
- * @param port
+ * @param port_id
  *   The port identifier of the Ethernet device.
  * @param rss_conf
  *   Where to store the current RSS hash configuration of the Ethernet device.
-- 
2.1.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: fix doxygen comments about RSS
  2014-11-24 22:09 [dpdk-dev] [PATCH] ethdev: fix doxygen comments about RSS Thomas Monjalon
@ 2014-11-25  8:47 ` Bruce Richardson
  2014-11-25 11:52   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2014-11-25  8:47 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On Mon, Nov 24, 2014 at 11:09:40PM +0100, Thomas Monjalon wrote:
> The parameters port_id didn't match with comments about port.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_ether/rte_ethdev.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index fec4d4c..78a9d37 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -3370,7 +3370,7 @@ int rte_eth_dev_bypass_wd_reset(uint8_t port);
>   /**
>   * Configuration of Receive Side Scaling hash computation of Ethernet device.
>   *
> - * @param port
> + * @param port_id
>   *   The port identifier of the Ethernet device.
>   * @param rss_conf
>   *   The new configuration to use for RSS hash computation on the port.
> @@ -3387,7 +3387,7 @@ int rte_eth_dev_rss_hash_update(uint8_t port_id,
>   * Retrieve current configuration of Receive Side Scaling hash computation
>   * of Ethernet device.
>   *
> - * @param port
> + * @param port_id
>   *   The port identifier of the Ethernet device.
>   * @param rss_conf
>   *   Where to store the current RSS hash configuration of the Ethernet device.
> -- 
> 2.1.3
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: fix doxygen comments about RSS
  2014-11-25  8:47 ` Bruce Richardson
@ 2014-11-25 11:52   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2014-11-25 11:52 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev

> > The parameters port_id didn't match with comments about port.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied

-- 
Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-11-25 11:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-24 22:09 [dpdk-dev] [PATCH] ethdev: fix doxygen comments about RSS Thomas Monjalon
2014-11-25  8:47 ` Bruce Richardson
2014-11-25 11:52   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).