From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 27CFE2E81 for ; Tue, 25 Nov 2014 11:10:49 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 25 Nov 2014 02:21:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,455,1413270000"; d="scan'208";a="637707412" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.15]) by fmsmga002.fm.intel.com with SMTP; 25 Nov 2014 02:21:36 -0800 Received: by (sSMTP sendmail emulation); Tue, 25 Nov 2014 10:21:36 +0025 Date: Tue, 25 Nov 2014 10:21:36 +0000 From: Bruce Richardson To: Thomas Monjalon Message-ID: <20141125102136.GA5260@bricha3-MOBL3> References: <1416692622-28886-1-git-send-email-thomas.monjalon@6wind.com> <1416692622-28886-2-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416692622-28886-2-git-send-email-thomas.monjalon@6wind.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 01/10] eal: move internal headers in source directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 10:10:49 -0000 On Sat, Nov 22, 2014 at 10:43:33PM +0100, Thomas Monjalon wrote: > The directory include/ should be reserved to public headers. > > Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson > --- > lib/librte_eal/bsdapp/eal/Makefile | 1 + > lib/librte_eal/common/{include => }/eal_options.h | 0 > lib/librte_eal/common/{include => }/eal_private.h | 0 > lib/librte_eal/linuxapp/eal/Makefile | 1 + > lib/librte_eal/linuxapp/eal/{include => }/eal_pci_init.h | 0 > lib/librte_eal/linuxapp/eal/{include => }/eal_vfio.h | 0 > 6 files changed, 2 insertions(+) > rename lib/librte_eal/common/{include => }/eal_options.h (100%) > rename lib/librte_eal/common/{include => }/eal_private.h (100%) > rename lib/librte_eal/linuxapp/eal/{include => }/eal_pci_init.h (100%) > rename lib/librte_eal/linuxapp/eal/{include => }/eal_vfio.h (100%) > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile > index ca943c1..4683fc3 100644 > --- a/lib/librte_eal/bsdapp/eal/Makefile > +++ b/lib/librte_eal/bsdapp/eal/Makefile > @@ -36,6 +36,7 @@ LIB = librte_eal.a > VPATH += $(RTE_SDK)/lib/librte_eal/common > > CFLAGS += -I$(SRCDIR)/include > +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common > CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include > CFLAGS += -I$(RTE_SDK)/lib/librte_ring > CFLAGS += -I$(RTE_SDK)/lib/librte_mempool > diff --git a/lib/librte_eal/common/include/eal_options.h b/lib/librte_eal/common/eal_options.h > similarity index 100% > rename from lib/librte_eal/common/include/eal_options.h > rename to lib/librte_eal/common/eal_options.h > diff --git a/lib/librte_eal/common/include/eal_private.h b/lib/librte_eal/common/eal_private.h > similarity index 100% > rename from lib/librte_eal/common/include/eal_private.h > rename to lib/librte_eal/common/eal_private.h > diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile > index c99433e..2480cb0 100644 > --- a/lib/librte_eal/linuxapp/eal/Makefile > +++ b/lib/librte_eal/linuxapp/eal/Makefile > @@ -36,6 +36,7 @@ LIB = librte_eal.a > VPATH += $(RTE_SDK)/lib/librte_eal/common > > CFLAGS += -I$(SRCDIR)/include > +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common > CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include > CFLAGS += -I$(RTE_SDK)/lib/librte_ring > CFLAGS += -I$(RTE_SDK)/lib/librte_mempool > diff --git a/lib/librte_eal/linuxapp/eal/include/eal_pci_init.h b/lib/librte_eal/linuxapp/eal/eal_pci_init.h > similarity index 100% > rename from lib/librte_eal/linuxapp/eal/include/eal_pci_init.h > rename to lib/librte_eal/linuxapp/eal/eal_pci_init.h > diff --git a/lib/librte_eal/linuxapp/eal/include/eal_vfio.h b/lib/librte_eal/linuxapp/eal/eal_vfio.h > similarity index 100% > rename from lib/librte_eal/linuxapp/eal/include/eal_vfio.h > rename to lib/librte_eal/linuxapp/eal/eal_vfio.h > -- > 2.1.3 >