From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 5D41A3975
 for <dev@dpdk.org>; Tue, 25 Nov 2014 14:26:29 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 25 Nov 2014 05:34:56 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,455,1413270000"; d="scan'208";a="613730842"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.15])
 by orsmga001.jf.intel.com with SMTP; 25 Nov 2014 05:37:18 -0800
Received: by  (sSMTP sendmail emulation); Tue, 25 Nov 2014 13:37:17 +0025
Date: Tue, 25 Nov 2014 13:37:17 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20141125133717.GA2300@bricha3-MOBL3>
References: <1416692622-28886-1-git-send-email-thomas.monjalon@6wind.com>
 <1416692622-28886-4-git-send-email-thomas.monjalon@6wind.com>
 <20141125102812.GC5260@bricha3-MOBL3> <5027116.j4eGpnoEV0@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5027116.j4eGpnoEV0@xps13>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 03/10] eal: fix header guards
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2014 13:26:30 -0000

On Tue, Nov 25, 2014 at 01:23:55PM +0100, Thomas Monjalon wrote:
> Thanks for your review, Bruce.
> More comments below.
> 
> 2014-11-25 10:28, Bruce Richardson:
> > On Sat, Nov 22, 2014 at 10:43:35PM +0100, Thomas Monjalon wrote:
> > > Some guards are missing or have a wrong name.
> > > Others have LINUXAPP in their name but are now common.
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > 
> > One minor comment below.
> > 
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> [...]
> > > -#ifndef _EAL_LINUXAPP_FILESYSTEM_H
> > > -#define _EAL_LINUXAPP_FILESYSTEM_H
> > > +#ifndef EAL_FILESYSTEM_H
> > > +#define EAL_FILESYSTEM_H
> > >  
> > >  /** Path of rte config file. */
> > >  #define RUNTIME_CONFIG_FMT "%s/.%s_config"
> > 
> > no ending comment for #endif - should one be added for completeness?
> > 
> > > @@ -115,4 +115,4 @@ eal_get_hugefile_temp_path(char *buffer, size_t buflen, const char *hugedir, int
> > >   * Used to read information from files on /sys */
> > >  int eal_parse_sysfs_value(const char *filename, unsigned long *val);
> > >  
> > > -#endif /* _EAL_LINUXAPP_FILESYSTEM_H */
> > > +#endif /* EAL_FILESYSTEM_H */
> 
> The ending comment is here.
> 
> > > --- a/lib/librte_eal/common/eal_internal_cfg.h
> > > +++ b/lib/librte_eal/common/eal_internal_cfg.h
> > > @@ -36,8 +36,8 @@
> > >   * Holds the structures for the eal internal configuration
> > >   */
> > >  
> > > -#ifndef _EAL_LINUXAPP_INTERNAL_CFG
> > > -#define _EAL_LINUXAPP_INTERNAL_CFG
> > > +#ifndef EAL_INTERNAL_CFG_H
> > > +#define EAL_INTERNAL_CFG_H
> > >  
> > >  #include <rte_eal.h>
> > >  #include <rte_pci_dev_feature_defs.h>
> 
> I've added an ending comment for this file.
> Is it the one you thought about?
>
Not sure, I just thought I missed seeing an ending comment on one of the pairs,
however, I'm sure you're on top of it (and if one is missed, it's no big deal
anyway).

/Bruce