From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 68EFE2A9 for ; Fri, 28 Nov 2014 14:18:55 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 28 Nov 2014 05:16:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,477,1413270000"; d="scan'208";a="645027925" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.19]) by orsmga002.jf.intel.com with SMTP; 28 Nov 2014 05:18:32 -0800 Received: by (sSMTP sendmail emulation); Fri, 28 Nov 2014 13:18:31 +0025 Date: Fri, 28 Nov 2014 13:18:31 +0000 From: Bruce Richardson To: Balazs Nemeth Message-ID: <20141128131831.GB10024@bricha3-MOBL3> References: <1417166505-486-1-git-send-email-balazs.nemeth@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417166505-486-1-git-send-email-balazs.nemeth@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: Add missing rx_mbuf_alloc_failed statistics for vector PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 13:18:55 -0000 On Fri, Nov 28, 2014 at 09:21:45AM +0000, Balazs Nemeth wrote: > The statistics that is reported through the rx_nombuf fields in struct > rte_eth_stats was not set when the vector PMD was used. The statistics > should report the number of mbufs that could _not_ be allocated during > rearm of the RX queue. The non-vector PMD reports it correctly. The > use of either vector PMD or non-vector PMD depends on runtime > configuration. Hence it is possible that a change in configuration > would disable this statistics. To prevent this from happening, the > statistics should be reported by both implementations. > > Signed-off-by: Balazs Nemeth Acked-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > index 42c0f60..579bc46 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > @@ -71,6 +71,8 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq) > dma_addr0); > } > } > + rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed += > + RTE_IXGBE_RXQ_REARM_THRESH; > return; > } > > -- > 2.1.2 >