From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DCF83231C for ; Fri, 28 Nov 2014 15:59:26 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 28 Nov 2014 06:59:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="422690366" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.19]) by FMSMGA003.fm.intel.com with SMTP; 28 Nov 2014 06:49:24 -0800 Received: by (sSMTP sendmail emulation); Fri, 28 Nov 2014 14:59:20 +0025 Date: Fri, 28 Nov 2014 14:59:20 +0000 From: Bruce Richardson To: David Marchand Message-ID: <20141128145920.GC3412@bricha3-MOBL3> References: <1417087745-9004-1-git-send-email-david.marchand@6wind.com> <4256507.tIOyuODinC@xps13> <20141128135604.GB5828@bricha3-MOBL3> <20141128144309.GB3412@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] scripts: fix symbol overriding in configuration files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 14:59:27 -0000 On Fri, Nov 28, 2014 at 03:49:29PM +0100, David Marchand wrote: > On Fri, Nov 28, 2014 at 3:43 PM, Bruce Richardson < > bruce.richardson@intel.com> wrote: > > > This proposed fix also works. I don't mind whether my patch proposal or > > this > > fix gets applied - gen-config-h.sh is not a commonly modified script > > anyway. > > > > I prefer my ugliness ;-) > But Thomas just proposed me something that could work. > Trying ... > Yes, it's ugly, but it's probably more resilient. I'm looking forward to getting an option C. /Bruce