From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 404399A8 for ; Sun, 30 Nov 2014 02:05:22 +0100 (CET) Received: from cpe-098-026-066-094.nc.res.rr.com ([98.26.66.94] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Xusww-00051v-D9; Sat, 29 Nov 2014 20:05:20 -0500 Date: Sat, 29 Nov 2014 20:05:14 -0500 From: Neil Horman To: Bruce Richardson Message-ID: <20141130010514.GA19479@localhost.localdomain> References: <1417188660-14587-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417188660-14587-1-git-send-email-bruce.richardson@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix clang compile - remove truncation errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Nov 2014 01:05:22 -0000 On Fri, Nov 28, 2014 at 03:31:00PM +0000, Bruce Richardson wrote: > When compiling with clang, errors were being emitted due to truncation > of values when assigning to the tx_offload_mask bit fields. > > dpdk.org/lib/librte_pmd_ixgbe/ixgbe_rxtx.c:404:27: fatal error: implicit truncation from 'int' to bitfield changes value from -1 to 127 [-Wbitfield-constant-conversion] > tx_offload_mask.l2_len = ~0; > > The fix proposed here is to define a static const value of the same type > with all fields set to 1s, and use that instead of constants for assigning to. > > Other options would be to explicitily define the suitable constants that > would not truncate for each individual field e.g. 0x7f for l2_len, 0x1FF > for l3_len, etc., but this solution here has the advantage that it works > without any changes to values if the field sizes are ever modified. > > Signed-off-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 29 +++++++++++++++-------------- > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > index 8559ef6..4f71194 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -367,6 +367,7 @@ ixgbe_set_xmit_ctx(struct igb_tx_queue* txq, > volatile struct ixgbe_adv_tx_context_desc *ctx_txd, > uint64_t ol_flags, union ixgbe_tx_offload tx_offload) > { > + static const union ixgbe_tx_offload offload_allones = { .data = ~0 }; Do you want to make this a static data structure? If you make it a macro like this: #define ALLONES {.data = ~0} Then you save the extra data space in the .data area (not that its that much), and you can define it in a header file and use it in multiple c files (if you need to) Neil