From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id EC4FA7FCB
 for <dev@dpdk.org>; Mon,  1 Dec 2014 12:17:14 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga101.jf.intel.com with ESMTP; 01 Dec 2014 03:17:13 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,493,1413270000"; d="scan'208";a="646146576"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.36])
 by orsmga002.jf.intel.com with SMTP; 01 Dec 2014 03:17:11 -0800
Received: by  (sSMTP sendmail emulation); Mon, 01 Dec 2014 11:17:11 +0025
Date: Mon, 1 Dec 2014 11:17:11 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
Message-ID: <20141201111710.GC4856@bricha3-MOBL3>
References: <1417245457-19609-1-git-send-email-ssujith@cisco.com>
 <20141201105756.GB4856@bricha3-MOBL3>
 <D0A247E2.292E0%ssujith@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <D0A247E2.292E0%ssujith@cisco.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] enicpd: Warnings and one error when built
 using clang compiler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2014 11:17:15 -0000

On Mon, Dec 01, 2014 at 11:06:43AM +0000, Sujith Sankar (ssujith) wrote:
> 
> On 01/12/14 4:27 pm, "Bruce Richardson" <bruce.richardson@intel.com> wrote:
> 
> >On Sat, Nov 29, 2014 at 12:47:37PM +0530, Sujith Sankar wrote:
> >> This patch fixes the warnings and error reported by clang compiler on
> >>Linux.
> >> 
> >> Reported-by: Bruce Richardson <bruce.richardson@intel.com>
> >> Signed-off-by: Sujith Sankar <ssujith@cisco.com>
> >
> >This PMD now compiles up with clang on FreeBSD. The patch seems rather
> >large though,
> >are all these changes necessary for clang compilation?
> 
> Yes.  This patch has only the changes to fix compilation on clang, and it
> modifies enic code only.
> 
> >
> >On the basis that this fixes the issue though:
> >
> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Thanks Bruce.
>
And thank you for providing a patch so quickly! :-)

/Bruce