From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2DB8D8032 for ; Thu, 4 Dec 2014 17:08:12 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 04 Dec 2014 08:06:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="493636513" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.34]) by orsmga003.jf.intel.com with SMTP; 04 Dec 2014 08:02:59 -0800 Received: by (sSMTP sendmail emulation); Thu, 04 Dec 2014 16:06:20 +0025 Date: Thu, 4 Dec 2014 16:06:20 +0000 From: Bruce Richardson To: Thomas Monjalon Message-ID: <20141204160619.GA10704@bricha3-MOBL3> References: <1417625819-3024-1-git-send-email-bruce.richardson@intel.com> <1770523.OPzYA99vBi@xps13> <20141204140324.GA4828@bricha3-MOBL3> <6007845.LEvoKu9qPf@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6007845.LEvoKu9qPf@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] examples: fix symmetric_mp, set NIC rx_drop_en bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 16:08:13 -0000 On Thu, Dec 04, 2014 at 04:36:42PM +0100, Thomas Monjalon wrote: > 2014-12-04 14:03, Bruce Richardson: > > On Thu, Dec 04, 2014 at 02:37:15PM +0100, Thomas Monjalon wrote: > > > 2014-12-03 16:56, Bruce Richardson: > > > > The symmetric_mp example app is set up to allow two processes to > > > > share a NIC port, with each pulling packets from one queue. In order > > > > to have the app continue working when one of the process dies, the > > > > drop_en bit should be set in the NIC configuration. Without this bit > > > > set, the NIC will stall once any queue fills. With the bit set, once > > > > a queue fills, all subsequent packets for that queue are discarded > > > > allowing other queues to continue operating as normal. > > > > > > > > This setting was missed when converting to use standardised defaults > > > > in commit 81f7ecd9. > > > > > > I don't see rx_drop_en in commit 81f7ecd9. > > > Why do you say it was missed? > > > > > This is the one app that needs the drop_en bit set, and the bit is not set in the > > defaults. Therefore, when this app was converted to use the defaults from the > > driver, the drop_en bit should have been explicitly set as in this patch. [The > > fact of there being no drop_en bit in the commit is proof of its absense :-)]. > > So you agree this bit was never been set for this app? > Therefore I should remove the last sentence of your commit log before applying? > > Oh, now I get your point. Looking at 1.7 release, yes, this bit was never set but should really have been set. Therefore, please remove the last line as you suggest. /Bruce