From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linville@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id A8D578047
 for <dev@dpdk.org>; Fri,  5 Dec 2014 17:30:10 +0100 (CET)
Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63)
 (envelope-from <linville@tuxdriver.com>)
 id 1Xwvlf-0002Qd-Hn; Fri, 05 Dec 2014 11:30:07 -0500
Received: from linville-x1.hq.tuxdriver.com (localhost.localdomain [127.0.0.1])
 by linville-x1.hq.tuxdriver.com (8.14.8/8.14.6) with ESMTP id sB5GOthF010402; 
 Fri, 5 Dec 2014 11:24:55 -0500
Received: (from linville@localhost)
 by linville-x1.hq.tuxdriver.com (8.14.8/8.14.8/Submit) id sB5GOsww010401;
 Fri, 5 Dec 2014 11:24:54 -0500
Date: Fri, 5 Dec 2014 11:24:53 -0500
From: "John W. Linville" <linville@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20141205162453.GB28319@tuxdriver.com>
References: <1417729325-9410-1-git-send-email-linville@tuxdriver.com>
 <8974312.4KPnm9h9PX@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8974312.4KPnm9h9PX@xps13>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_pmd_af_packet: add compile-time
 checks for kernel-specific options
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Dec 2014 16:30:10 -0000

On Fri, Dec 05, 2014 at 10:30:53AM +0100, Thomas Monjalon wrote:
> Hi John,
> 
> 2014-12-04 16:42, John W. Linville:
> > This allows the PMD to compile with kernels that don't support the
> > options in question.  The "#if defined(...)" lines are a bit ugly,
> > but I don't know of any better way to accomplish the task.
> > 
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > ---
> >  lib/librte_pmd_af_packet/rte_eth_af_packet.c | 16 ++++++++++++----
> >  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> Is it possible to enable compilation of this PMD in default configuration?
> I guess it shouldn't fail anymore with this patch?

Yes, I believe so.  I checked the kernel git history for when each
definition was included.  Everything else was older than the 2.6.32
kernel.

I think you can reenable this PMD in the common_linuxapp config file
if you like.  I'll send a patch if you prefer for me to do so.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.