From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 9FBC03B5
 for <dev@dpdk.org>; Mon,  8 Dec 2014 15:26:21 +0100 (CET)
Received: from rrcs-70-62-112-196.midsouth.biz.rr.com ([70.62.112.196]
 helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1XxzG6-0000mb-Hv; Mon, 08 Dec 2014 09:26:04 -0500
Date: Mon, 8 Dec 2014 09:25:48 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Message-ID: <20141208142548.GB3237@localhost.localdomain>
References: <1418029178-25162-1-git-send-email-zlu@ezchip.com>
 <1418029178-25162-2-git-send-email-zlu@ezchip.com>
 <20141208110912.GA10196@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141208110912.GA10196@bricha3-MOBL3>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org, Cyril Chemparathy <cchemparathy@ezchip.com>
Subject: Re: [dpdk-dev] [PATCH 01/15] mk: introduce Tilera Tile architecture
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Dec 2014 14:26:21 -0000

On Mon, Dec 08, 2014 at 11:09:13AM +0000, Bruce Richardson wrote:
> On Mon, Dec 08, 2014 at 04:59:24PM +0800, Zhigang Lu wrote:
> > Add defconfig and rte.vars.mk files for Tile architecture.
> > 
> > Signed-off-by: Zhigang Lu <zlu@ezchip.com>
> > Signed-off-by: Cyril Chemparathy <cchemparathy@ezchip.com>
> > ---
> >  config/defconfig_tile-tilegx-linuxapp-gcc | 78 +++++++++++++++++++++++++++++++
> >  mk/arch/tile/rte.vars.mk                  | 59 +++++++++++++++++++++++
> >  mk/machine/tilegx/rte.vars.mk             | 58 +++++++++++++++++++++++
> >  3 files changed, 195 insertions(+)
> >  create mode 100644 config/defconfig_tile-tilegx-linuxapp-gcc
> >  create mode 100644 mk/arch/tile/rte.vars.mk
> >  create mode 100644 mk/machine/tilegx/rte.vars.mk
> >
> 
> I think this should probably be the final patch in the series, rather than the
> first. It's generally best to set up all requirements first before enabling things
> in the compile time configuration. Once this patch is added, there is a non-functional
> target added for tile architecture. If it's added last, the moment the compile
> time config is added it works correctly.
> 
> /Bruce
> 
> 
Agreed, this should be last.  Also, just for clarity, you're posting this very
close to the 1.8 release.  I presume your intent is to add this in for the 2.0
release, correct?
Neil