From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 0C8D8DE0 for ; Mon, 8 Dec 2014 15:28:29 +0100 (CET) Received: from rrcs-70-62-112-196.midsouth.biz.rr.com ([70.62.112.196] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1XxzIP-0000nY-Ao; Mon, 08 Dec 2014 09:28:25 -0500 Date: Mon, 8 Dec 2014 09:28:10 -0500 From: Neil Horman To: Zhigang Lu Message-ID: <20141208142810.GC3237@localhost.localdomain> References: <1418029178-25162-1-git-send-email-zlu@ezchip.com> <1418029178-25162-3-git-send-email-zlu@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418029178-25162-3-git-send-email-zlu@ezchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org, Cyril Chemparathy Subject: Re: [dpdk-dev] [PATCH 02/15] eal/tile: add atomic operations for TileGx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2014 14:28:29 -0000 On Mon, Dec 08, 2014 at 04:59:25PM +0800, Zhigang Lu wrote: > This patch adds architecture specific memory barrier operations for > TileGx. > > Signed-off-by: Zhigang Lu > Signed-off-by: Cyril Chemparathy > --- > .../common/include/arch/tile/rte_atomic.h | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 lib/librte_eal/common/include/arch/tile/rte_atomic.h > > diff --git a/lib/librte_eal/common/include/arch/tile/rte_atomic.h b/lib/librte_eal/common/include/arch/tile/rte_atomic.h > new file mode 100644 > index 0000000..24c9b0a > --- /dev/null > +++ b/lib/librte_eal/common/include/arch/tile/rte_atomic.h > @@ -0,0 +1,62 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2014 Tilera Corporation. All rights reserved. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Tilera Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#ifndef _RTE_ATOMIC_TILE_H_ > +#define _RTE_ATOMIC_TILE_H_ > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +#include "generic/rte_atomic.h" > + > +static inline void rte_mb(void) > +{ > + __sync_synchronize(); > +} > + > +static inline void rte_wmb(void) > +{ > + __sync_synchronize(); > +} > + > +static inline void rte_rmb(void) > +{ > + __sync_synchronize(); I don't see __sync_synchronize defined anywhere. Is that an intrinsic for gcc, or a library call? Neil