From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id D064CCE7
 for <dev@dpdk.org>; Mon,  8 Dec 2014 15:49:32 +0100 (CET)
Received: from rrcs-70-62-112-196.midsouth.biz.rr.com ([70.62.112.196]
 helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1Xxzch-0000uD-KJ; Mon, 08 Dec 2014 09:49:25 -0500
Date: Mon, 8 Dec 2014 09:49:10 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: stepan <stepan.sojka@adaptivemobile.com>
Message-ID: <20141208144910.GE3237@localhost.localdomain>
References: <kzlhosux2e.fsf@adaptivemobile.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <kzlhosux2e.fsf@adaptivemobile.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-dev,
	pcap] pcap: fix build of all-in-one shared library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Dec 2014 14:49:33 -0000

On Tue, Oct 07, 2014 at 12:14:04AM +0100, stepan wrote:
> Build of some of the test binaries fails when the following flags are enabled:
> 
> CONFIG_RTE_LIBRTE_PMD_PCAP=y
> CONFIG_RTE_BUILD_SHARED_LIB=y
> CONFIG_RTE_BUILD_COMBINE_LIBS=y
> 
> The binarieas are missing symbols from libpcap. This
> patch adds the missing '-lpcap' linker flag into the respective Makefiles.
> 
> Signed-off-by: stepan <stepan.sojka@adaptivemobile.com>
> 
> ---
> app/cmdline_test/Makefile | 4 ++++
>  app/dump_cfg/Makefile     | 4 ++++
>  app/test-acl/Makefile     | 4 ++++
>  app/test/Makefile         | 4 ++++
>  4 files changed, 16 insertions(+)
> 
> diff --git a/app/cmdline_test/Makefile b/app/cmdline_test/Makefile
> index e9eafd2..ce44fd5 100644
> --- a/app/cmdline_test/Makefile
> +++ b/app/cmdline_test/Makefile
> @@ -47,6 +47,10 @@ SRCS-y += commands.c
>  CFLAGS += -O3
>  CFLAGS += $(WERROR_FLAGS)
>  
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
> +LDFLAGS += -lpcap
> +endif
> +
>  include $(RTE_SDK)/mk/rte.app.mk
>  
>  endif
> diff --git a/app/dump_cfg/Makefile b/app/dump_cfg/Makefile
> index 3257127..513ce59 100644
> --- a/app/dump_cfg/Makefile
> +++ b/app/dump_cfg/Makefile
> @@ -35,6 +35,10 @@ APP = dump_cfg
>  
>  CFLAGS += $(WERROR_FLAGS)
>  
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
> +LDFLAGS += -lpcap
> +endif
> +
>  # all source are stored in SRCS-y
>  
>  SRCS-y := main.c
> diff --git a/app/test-acl/Makefile b/app/test-acl/Makefile
> index 43dfdcb..ea063fd 100644
> --- a/app/test-acl/Makefile
> +++ b/app/test-acl/Makefile
> @@ -37,6 +37,10 @@ APP = testacl
>  
>  CFLAGS += $(WERROR_FLAGS)
>  
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
> +LDFLAGS += -lpcap
> +endif
> +
>  # all source are stored in SRCS-y
>  SRCS-y := main.c
>  
> diff --git a/app/test/Makefile b/app/test/Makefile
> index 6af6d76..e456140 100644
> --- a/app/test/Makefile
> +++ b/app/test/Makefile
> @@ -145,6 +145,10 @@ CFLAGS_test_kni.o += -Wno-deprecated-declarations
>  endif
>  CFLAGS += -D_GNU_SOURCE
>  
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
> +LDFLAGS += -lpcap
> +endif
> +
>  # this application needs libraries first
>  DEPDIRS-y += lib
>  
Acked-by: Neil Horman <nhorman@tuxdriver.com>