From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id D4C8B3F9 for ; Tue, 9 Dec 2014 15:07:33 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1XyLRW-0005S5-IK; Tue, 09 Dec 2014 09:07:24 -0500 Date: Tue, 9 Dec 2014 09:07:00 -0500 From: Neil Horman To: Zhigang Lu Message-ID: <20141209140700.GB28871@hmsreliant.think-freely.org> References: <1418029178-25162-1-git-send-email-zlu@ezchip.com> <1418029178-25162-13-git-send-email-zlu@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418029178-25162-13-git-send-email-zlu@ezchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 12/15] eal/tile: add mPIPE buffer stack mempool provider X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Dec 2014 14:07:34 -0000 On Mon, Dec 08, 2014 at 04:59:35PM +0800, Zhigang Lu wrote: > TileGX: Modified mempool to allow for variable metadata. > Signed-off-by: Zhigang Lu > Signed-off-by: Cyril Chemparathy > --- > app/test-pmd/mempool_anon.c | 2 +- > app/test/Makefile | 6 +- > app/test/test_mempool_tile.c | 217 ++++++++++++ > lib/Makefile | 5 + > lib/librte_eal/linuxapp/eal/Makefile | 4 + > lib/librte_mempool_tile/Makefile | 48 +++ > lib/librte_mempool_tile/rte_mempool.c | 381 ++++++++++++++++++++ > lib/librte_mempool_tile/rte_mempool.h | 634 ++++++++++++++++++++++++++++++++++ > 8 files changed, 1295 insertions(+), 2 deletions(-) > create mode 100644 app/test/test_mempool_tile.c > create mode 100644 lib/librte_mempool_tile/Makefile > create mode 100644 lib/librte_mempool_tile/rte_mempool.c > create mode 100644 lib/librte_mempool_tile/rte_mempool.h > NAK, this creates an alternate, parallel implementation of the mempool api, that re-implements some aspects of the mempool api, but not others. This will make for completely no-portable applications (both to and from the tile arch), and create maintnence problems, in that features for mempool will need to be implemented in multiple libraries. I understand wanting to use mpipe, and thats perfectly fine, but creating no-portable apis to do so isn't the right way to go. Instead, why not just allow applications to use mpipe by initalizing it via the gxio library and crating a mempool using the existing libraries' rte_mempool_xmem_create api call, which allows for existing allocated memory space to be managed as a mempool? Neil