From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id A384E6A95 for ; Thu, 11 Dec 2014 00:44:04 +0100 (CET) Received: by mail-pa0-f45.google.com with SMTP id lf10so3181235pab.4 for ; Wed, 10 Dec 2014 15:44:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=w2ITl2uboNu/Q31hGIOMahHJqvpiLyMLroY3oC8fdQg=; b=dX9/t9HZ0bSeTFVuEPkIMqGiQ2ZIyubbRbMd7Mc475wZmY4arJbKStttMF5qLph3co qwV7Jsa3hQzMeTGPA9D7iL1XjoE8hbKT7iL62P+ly2tGN8LcbSJG5dfrmkDXmWMi8qys ersOE+fhCqedawjTzkSFQvSLU4moufU+F+SDO+1eFYRG689EQrXMO74Cbmr9uPqkJwxq eWXeMtKoABA47aazvuT1HYg4ZwyoL55iGm2QvduvshTD5YH10btlCkeGwalzjvBVsu4x z4Qv8QqKmuisZ3ETYTQvaTpxzd1IJP1UUeFeSCn+BDcQ0lVBRX5CWP09yI8kRGYXkeqG ViAQ== X-Gm-Message-State: ALoCoQmfyrWUOd/ch+ffLAlB15tLoMEvIYffeLcK/HVG8eU5o7Etw5lggBTCTDjTGfCldJCDi4r+ X-Received: by 10.70.46.201 with SMTP id x9mr11729372pdm.154.1418255043815; Wed, 10 Dec 2014 15:44:03 -0800 (PST) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id ps2sm5196328pdb.62.2014.12.10.15.44.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Dec 2014 15:44:03 -0800 (PST) Date: Wed, 10 Dec 2014 15:43:53 -0800 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20141210154353.6d94e025@urahara> In-Reply-To: <4172805.tCufcf6XqG@xps13> References: <20141209083724.1a6872ac@urahara> <4172805.tCufcf6XqG@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: support X540 VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 23:44:04 -0000 On Thu, 11 Dec 2014 00:23:24 +0100 Thomas Monjalon wrote: > 2014-12-09 08:37, Stephen Hemminger: > > Add missing setup for X540 MAC type when setting up VF. > > Additional check exists in Linux driver but not in DPDK. > > > > Signed-off-yb: Bill Hong > > Signed-off-by: Stephen Hemminger > > > > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c 2014-12-08 09:26:18.150170081 -0800 > > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c 2014-12-08 09:26:18.150170081 -0800 > > @@ -1911,7 +1911,8 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_ > > /* > > * Modification to set VFTDT for virtual function if vf is detected > > */ > > - if (hw->mac.type == ixgbe_mac_82599_vf) > > + if (hw->mac.type == ixgbe_mac_82599_vf || > > + hw->mac.type == ixgbe_mac_X540_vf) > > What about X550? Should it be listed there? > > > txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx)); > > else > > txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx)); > > @@ -2198,7 +2199,8 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_ > > /* > > * Modified to setup VFRDT for Virtual Function > > */ > > - if (hw->mac.type == ixgbe_mac_82599_vf) { > > + if (hw->mac.type == ixgbe_mac_82599_vf || > > + hw->mac.type == ixgbe_mac_X540_vf) { > > rxq->rdt_reg_addr = > > IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx)); > > rxq->rdh_reg_addr = > > It appears to be a fix which is candidate for 1.8.0. > > Thanks Not sure, we didnt have X550 to test, and code for X550 is not in upstream Linux kernel driver.