From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id F25EC6A95 for ; Thu, 11 Dec 2014 18:08:14 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 11 Dec 2014 09:05:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,558,1413270000"; d="scan'208";a="652346754" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.26]) by orsmga002.jf.intel.com with SMTP; 11 Dec 2014 09:07:23 -0800 Received: by (sSMTP sendmail emulation); Thu, 11 Dec 2014 17:07:21 +0025 Date: Thu, 11 Dec 2014 17:07:21 +0000 From: Bruce Richardson To: "Pattan, Reshma" Message-ID: <20141211170720.GA11672@bricha3-MOBL3> References: <533710CFB86FA344BFBF2D6802E60286C9D147@SHSMSX101.ccr.corp.intel.com> <1417787182-20712-1-git-send-email-bruce.richardson@intel.com> <3AEA2BF9852C6F48A459DA490692831FE4C138@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3AEA2BF9852C6F48A459DA490692831FE4C138@IRSMSX109.ger.corp.intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix multi-process support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2014 17:08:15 -0000 On Thu, Dec 11, 2014 at 04:58:42PM +0000, Pattan, Reshma wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Friday, December 5, 2014 1:46 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] ixgbe: fix multi-process support > > > > When using multiple processes, the TX function used in all processes should be > > the same, otherwise the secondary processes cannot transmit more than tx- > > ring-size - 1 packets. > > To achieve this, we extract out the code to select the ixgbe TX function to be > > used into a separate function inside the ixgbe driver, and call that from a > > secondary process when it is attaching to an already-configured NIC. > > > > Testing with symmetric MP app shows that we are able to RX and TX from both > > primary and secondary processes once this patch is applied. > > > > Signed-off-by: Bruce Richardson > > > > ---- > > V2 Changes: > > * Moved check for primary/secondary process into set_tx_function instead > > of ixgbe_txq_vec_setup, which reduces scope of diff. > > * Added/cleaned up some code comments for this change > > --- > Acked-by: Reshma Pattan > With comment " checkpatch shows whitespace errors which got copied from old code" Thomas, can you fix the whitespace problems when you apply, or do you want a V3? /Bruce