From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 72FB1959 for ; Mon, 15 Dec 2014 17:00:23 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Y0Y4F-0002z7-GV; Mon, 15 Dec 2014 11:00:22 -0500 Date: Mon, 15 Dec 2014 11:00:09 -0500 From: Neil Horman To: Konstantin Ananyev Message-ID: <20141215160009.GC3803@hmsreliant.think-freely.org> References: <1418580659-12595-1-git-send-email-konstantin.ananyev@intel.com> <1418580659-12595-11-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418580659-12595-11-git-send-email-konstantin.ananyev@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new rte_acl_classify() method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Dec 2014 16:00:23 -0000 On Sun, Dec 14, 2014 at 06:10:52PM +0000, Konstantin Ananyev wrote: > Introduce new classify() method that uses AVX2 instructions. > From my measurements: > On HSW boards when processing >= 16 packets per call, > AVX2 method outperforms it's SSE counterpart by 10-25%, > (depending on the ruleset). > At runtime, this method is selected as default one on HW that supports AVX2. > > Signed-off-by: Konstantin Ananyev > --- > lib/librte_acl/Makefile | 9 + > lib/librte_acl/acl.h | 4 + > lib/librte_acl/acl_run.h | 2 +- > lib/librte_acl/acl_run_avx2.c | 58 +++++ > lib/librte_acl/acl_run_avx2.h | 305 ++++++++++++++++++++++++ > lib/librte_acl/acl_run_sse.c | 537 +----------------------------------------- > lib/librte_acl/acl_run_sse.h | 533 +++++++++++++++++++++++++++++++++++++++++ > lib/librte_acl/rte_acl.c | 5 +- > lib/librte_acl/rte_acl.h | 2 + > 9 files changed, 917 insertions(+), 538 deletions(-) > create mode 100644 lib/librte_acl/acl_run_avx2.c > create mode 100644 lib/librte_acl/acl_run_avx2.h > create mode 100644 lib/librte_acl/acl_run_sse.h > > diff --git a/lib/librte_acl/Makefile b/lib/librte_acl/Makefile > index 65e566d..223ec31 100644 > --- a/lib/librte_acl/Makefile > +++ b/lib/librte_acl/Makefile > @@ -45,8 +45,17 @@ SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_bld.c > SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_gen.c > SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_scalar.c > SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_sse.c > +SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_avx2.c > > CFLAGS_acl_run_sse.o += -msse4.1 > +ifeq ($(CC), icc) > +CFLAGS_acl_run_avx2.o += -march=core-avx2 > +else ifneq ($(shell \ > +test $(GCC_MAJOR_VERSION) -le 4 -a $(GCC_MINOR_VERSION) -le 6 && echo 1), 1) > +CFLAGS_acl_run_avx2.o += -mavx2 > +else > +CFLAGS_acl_run_avx2.o += -msse4.1 > +endif > This seems broken. You've unilaterally included acl_run_avx2.c in the build list above, but only enable -mavx2 if the compiler is at least gcc 4.6. Unless you want to make gcc 4.6 a requirement for building, you need to also exclude the file above from the build list. That in turn I think allows you to remove a bunch of the ifdeffing that you've done in some of the avx2 specific files. Neil