DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] testpmd: limit port mask bits to RTE_MAX_ETHPORTS
Date: Tue, 16 Dec 2014 13:50:06 +0000	[thread overview]
Message-ID: <20141216135006.GA11716@bricha3-MOBL3> (raw)
In-Reply-To: <2281526.Jgy67gTqhP@xps13>

On Tue, Dec 16, 2014 at 02:40:09PM +0100, Thomas Monjalon wrote:
> 2014-12-16 13:27, Bruce Richardson:
> > The port mask parsing in testpmd allowed up to 64 bits to be processed,
> > even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only
> > processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask.
> [...]
> > -	for (i = 0; i < 64; i++) {
> > +	for (i = 0; i < 64 && i < RTE_MAX_ETHPORTS; i++) {
> 
> Why not use RTE_MIN?
> 
> -- 
> Thomas

Because this works equally well, and the change is simpler and clearer IMHO.
However, if you feel very strongly about it, I can change it to use RTE_MIN
instead. :-)

/Bruce

  reply	other threads:[~2014-12-16 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-16 13:27 Bruce Richardson
2014-12-16 13:40 ` Thomas Monjalon
2014-12-16 13:50   ` Bruce Richardson [this message]
2014-12-16 14:09     ` Neil Horman
2014-12-16 14:39       ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2014-12-16 21:43         ` Neil Horman
2014-12-17  0:09           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141216135006.GA11716@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).