From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DCC493F9 for ; Tue, 16 Dec 2014 14:50:10 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 16 Dec 2014 05:48:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,587,1413270000"; d="scan'208";a="624591047" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.28]) by orsmga001.jf.intel.com with SMTP; 16 Dec 2014 05:50:07 -0800 Received: by (sSMTP sendmail emulation); Tue, 16 Dec 2014 13:50:06 +0025 Date: Tue, 16 Dec 2014 13:50:06 +0000 From: Bruce Richardson To: Thomas Monjalon Message-ID: <20141216135006.GA11716@bricha3-MOBL3> References: <1418736437-30585-1-git-send-email-bruce.richardson@intel.com> <2281526.Jgy67gTqhP@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2281526.Jgy67gTqhP@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] testpmd: limit port mask bits to RTE_MAX_ETHPORTS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2014 13:50:11 -0000 On Tue, Dec 16, 2014 at 02:40:09PM +0100, Thomas Monjalon wrote: > 2014-12-16 13:27, Bruce Richardson: > > The port mask parsing in testpmd allowed up to 64 bits to be processed, > > even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only > > processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask. > [...] > > - for (i = 0; i < 64; i++) { > > + for (i = 0; i < 64 && i < RTE_MAX_ETHPORTS; i++) { > > Why not use RTE_MIN? > > -- > Thomas Because this works equally well, and the change is simpler and clearer IMHO. However, if you feel very strongly about it, I can change it to use RTE_MIN instead. :-) /Bruce