From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id ECDE73F9 for ; Wed, 17 Dec 2014 15:10:07 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 17 Dec 2014 06:06:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="500202659" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.28]) by orsmga003.jf.intel.com with SMTP; 17 Dec 2014 06:04:12 -0800 Received: by (sSMTP sendmail emulation); Wed, 17 Dec 2014 14:08:27 +0025 Date: Wed, 17 Dec 2014 14:08:27 +0000 From: Bruce Richardson To: Olivier Matz Message-ID: <20141217140826.GE9184@bricha3-MOBL3> References: <1418820925-20318-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418820925-20318-1-git-send-email-olivier.matz@6wind.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/5] fix compilation issues seen with clang-3.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 14:10:08 -0000 On Wed, Dec 17, 2014 at 01:55:20PM +0100, Olivier Matz wrote: > This series are compilation fixes seen with clang-3.5 on linux. > > Olivier Matz (5): > test-devargs: fix misplaced braces in strncmp call > examples/l3fwd: fix compilation with clang 3.5 > examples/netmap: fix overflow in ioctl operation > examples/vm_power_manager: move -lvirt in LDLIBS > examples/vm_power_manager: fix initialization of cmdline token > > app/test/test_devargs.c | 2 +- > examples/l3fwd/main.c | 4 +++- > examples/netmap_compat/lib/compat_netmap.c | 2 +- > examples/netmap_compat/lib/compat_netmap.h | 2 +- > examples/vm_power_manager/Makefile | 4 +++- > examples/vm_power_manager/vm_power_cli.c | 2 +- > 6 files changed, 10 insertions(+), 6 deletions(-) > > -- > 2.1.3 > Interesting. I've just upgraded to Fedora 21, and I'm getting a lot of other, different errors on compilation using its version of clang (3.4.2). Patches soon to follow, but I'm surprised that they don't show up in clang 3.5. Perhaps they are just compiler bugs in the Fedora version. Examples of the errors are shown below. /Bruce CC cmdline_rdline.o /home/bruce/dpdk.org/lib/librte_cmdline/cmdline_rdline.c:249:27: fatal error: equality comparison with extraneous parentheses [-Wparentheses-equality] if (((&rdl->left)->len == 0)) ~~~~~~~~~~~~~~~~~~^~~~ /home/bruce/dpdk.org/lib/librte_cmdline/cmdline_rdline.c:249:27: note: remove extraneous parentheses around the comparison to silence this warning if (((&rdl->left)->len == 0)) ~ ^ ~ /home/bruce/dpdk.org/lib/librte_cmdline/cmdline_rdline.c:249:27: note: use '=' to turn this equality comparison into an assignment if (((&rdl->left)->len == 0)) ^~ = 1 error generated. CC eal.o clang: fatal error: argument unused during compilation: '-I /home/bruce/dpdk.org/x86_64-native-linuxap /home/bruce/dpdk.org/mk/internal/rte.compile-pre.mk:126: recipe for target 'eal.o' failed gmake[7]: *** [eal.o] Error 1