From: Bruce Richardson <bruce.richardson@intel.com>
To: Jay Rolette <rolette@infiniteio.com>
Cc: Dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library
Date: Wed, 17 Dec 2014 15:27:19 +0000 [thread overview]
Message-ID: <20141217152718.GG9184@bricha3-MOBL3> (raw)
In-Reply-To: <CADNuJVpObspy7zW6D4Aww8LZNezgP8twrYp_Hej5ZFD1+L0ZKQ@mail.gmail.com>
On Wed, Dec 17, 2014 at 09:07:45AM -0600, Jay Rolette wrote:
>
> > Comments shall be C-style (/* */).
> >
>
> Single line comments ('//') have been part of the C standard since C99. Is
> DPDK following C89 or is this just a style thing? If it is a style thing, a
> link to a page with the rubric would be helpful. I didn't see one on the
> submission guidelines.
>
To to add here that I'd love to see the coding guidelines relaxed to allow
"//" style comments!
/Bruce
next prev parent reply other threads:[~2014-12-17 15:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 13:31 Jay Rolette
2014-12-17 14:27 ` Thomas Monjalon
2014-12-17 15:07 ` Jay Rolette
2014-12-17 15:27 ` Bruce Richardson [this message]
2015-09-09 10:35 ` Gonzalez Monroy, Sergio
2015-09-10 11:49 ` Jay Rolette
-- strict thread matches above, loose matches on Subject: below --
2014-12-11 16:05 Jay Rolette
2014-12-15 9:05 ` Wodkowski, PawelX
2014-12-15 13:17 ` Jay Rolette
2014-12-15 13:20 ` Wodkowski, PawelX
2014-12-15 14:29 ` Jay Rolette
2014-12-15 14:55 ` Richardson, Bruce
2014-12-15 14:24 ` Ananyev, Konstantin
2014-12-16 18:39 ` Ananyev, Konstantin
2014-12-16 19:18 ` Jay Rolette
2014-12-16 19:20 ` Jay Rolette
2014-12-17 11:00 ` Ananyev, Konstantin
2014-12-17 13:08 ` Qiu, Michael
2014-12-17 13:35 ` Jay Rolette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217152718.GG9184@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rolette@infiniteio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).