From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 886FC68AA for ; Wed, 17 Dec 2014 16:27:51 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 17 Dec 2014 07:25:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,594,1413270000"; d="scan'208";a="625295046" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.28]) by orsmga001.jf.intel.com with SMTP; 17 Dec 2014 07:27:19 -0800 Received: by (sSMTP sendmail emulation); Wed, 17 Dec 2014 15:27:19 +0025 Date: Wed, 17 Dec 2014 15:27:19 +0000 From: Bruce Richardson To: Jay Rolette Message-ID: <20141217152718.GG9184@bricha3-MOBL3> References: <1418823077-9129-1-git-send-email-rolette@infiniteio.com> <1667884.VTnHUhe7ya@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Dev Subject: Re: [dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 15:27:52 -0000 On Wed, Dec 17, 2014 at 09:07:45AM -0600, Jay Rolette wrote: > > > Comments shall be C-style (/* */). > > > > Single line comments ('//') have been part of the C standard since C99. Is > DPDK following C89 or is this just a style thing? If it is a style thing, a > link to a page with the rubric would be helpful. I didn't see one on the > submission guidelines. > To to add here that I'd love to see the coding guidelines relaxed to allow "//" style comments! /Bruce