From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
 [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 43B837F70
 for <dev@dpdk.org>; Thu, 18 Dec 2014 17:17:26 +0100 (CET)
Received: by mail-pa0-f48.google.com with SMTP id rd3so1685377pab.7
 for <dev@dpdk.org>; Thu, 18 Dec 2014 08:17:25 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=eYOeNsTukl752Kd1mZtYq7H9z/uOJ8HnFmzcAXvke58=;
 b=F2KnIAYQHtfFF/pdSajJn3oiHVn7INNvU3V41zM+MWyoYyjMq08oGKf07zcwvTQlUY
 TYRLVz8/xJgqSoM6L2u6YP6znYphGn6enH6AnCbS/qndBExSV9mEXvV3Hcp+Qqz0G+Nb
 M+bKK+OB/f8Usvgnhbm7tPYAUKLsHOtIM/x3XDP03jJi6MBq6hVTwLaDN/3kUl/Jw9OU
 otrEsf2y/fC6nvUp77msjZent3kF021zuCd1h2Jxk/zkiR+7GO7eKLniaU5OGsBhA+iD
 Hh+MfBzqDUbAiY2o6R1c1rEmlw35yDm8gt9qmEpv0gHSpvHfGhh6fQc5PcFsCoZOeSVw
 T0Jw==
X-Gm-Message-State: ALoCoQlx2dbrr0iYyqOnR7oeZjpzYm3hfjOFx2AQUnDw19n7XjoGU+N8OKj3SX2rys7tsWhxjvci
X-Received: by 10.70.133.69 with SMTP id pa5mr4620815pdb.59.1418919445289;
 Thu, 18 Dec 2014 08:17:25 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id ri3sm7185043pdb.58.2014.12.18.08.17.22
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 18 Dec 2014 08:17:24 -0800 (PST)
Date: Thu, 18 Dec 2014 08:17:12 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Neil Horman <nhorman@tuxdriver.com>
Message-ID: <20141218081712.62ebca0c@urahara>
In-Reply-To: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com>
References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] xenvirt: Fix build break on
 cmdline_parse_etheraddr call
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2014 16:17:26 -0000

On Wed, 17 Dec 2014 12:03:28 -0500
Neil Horman <nhorman@tuxdriver.com> wrote:

> Back in:
> 
> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db
> Author: Alan Carew <alan.carew@intel.com>
> Date:   Fri Dec 5 15:19:07 2014 +0100
> 
>     cmdline: fix overflow on bsd
> 
> The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt.  This
> patch makes the needed correction to avoid a build break
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Thomas Monjalon <thomas.monjalon@6wind.com>

If we could fix the header incompatiablities then the driver could use
a standard library like ether_aton() instead of dragging in the unnecessary
cmdline library.