From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 999792A1A for ; Thu, 18 Dec 2014 20:58:27 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Y1hDK-00009p-J1; Thu, 18 Dec 2014 14:58:24 -0500 Date: Thu, 18 Dec 2014 14:58:21 -0500 From: Neil Horman To: "Qiu, Michael" Message-ID: <20141218195821.GE18008@hmsreliant.think-freely.org> References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com> <2522675.0gKbYfjInz@xps13> <20141218112523.GA18008@hmsreliant.think-freely.org> <533710CFB86FA344BFBF2D6802E60286CA0EE5@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CA0EE5@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 19:58:27 -0000 On Thu, Dec 18, 2014 at 01:51:13PM +0000, Qiu, Michael wrote: > On 2014/12/18 19:26, Neil Horman wrote: > > On Wed, Dec 17, 2014 at 11:20:26PM +0100, Thomas Monjalon wrote: > >> Hi Neil, > >> > >> 2014-12-17 12:03, Neil Horman: > >>> Back in: > >>> > >>> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db > >>> Author: Alan Carew > >>> Date: Fri Dec 5 15:19:07 2014 +0100 > >>> > >>> cmdline: fix overflow on bsd > >>> > >>> The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This > >>> patch makes the needed correction to avoid a build break > >>> > >>> Signed-off-by: Neil Horman > >>> CC: Thomas Monjalon > >> What is the meaning of CC here? > >> > > CC is a tag that git send-email understands. As it implies it cc's the post to > > the indicated email, and records that fact in the body of the commit. > > But if you use --cc in git send-email will be a good choice. CC list is > useless for patch it self, but here it will exist in commit log(although > this style can also be seen in linux kernel) Yes, its good to have a record of who was CCed on a patch for archival purposes, so you can get an idea of who participated (or was expected to participate in a review) Neil > > Thanks, > Michael > >>> --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c > >>> +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c > >>> @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict, > >>> if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM, > >>> sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) { > >>> if (cmdline_parse_etheraddr(NULL, > >>> - pair[1], > >>> - &dict->addr) < 0) { > >>> + pair[1], > >>> + &dict->addr, > >>> + sizeof(struct ether_addr)) < 0) { > >> Why not sizeof(dict->addr)? > >> > > Because addr is a struct ether_addr, and I always get confused when doing sizeof > > on pointer variables, so I find it more clear to specify the type exactly. I'm > > not bound to it though so if you like I can change it, though given its release > > day, I figure you want to fix this build break asap. > > Neil > > > >> -- > >> Thomas > >> > >