From: Neil Horman <nhorman@tuxdriver.com> To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning Date: Mon, 22 Dec 2014 11:22:27 -0500 Message-ID: <20141222162227.GC26669@hmsreliant.think-freely.org> (raw) In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F20D71@IRSMSX108.ger.corp.intel.com> On Mon, Dec 22, 2014 at 02:01:10PM +0000, Gonzalez Monroy, Sergio wrote: > Hi Neil, > > Just a couple of minor comments. > > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > Sent: Saturday, December 20, 2014 9:02 PM > > Subject: [PATCH 1/4] compat: Add infrastructure to support symbol > > versioning > > > > Add initial pass header files to support symbol versioning. > > > [...] > > > > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 81bf8e1..2299cbe 100644 > > --- a/mk/rte.lib.mk > > +++ b/mk/rte.lib.mk > > @@ -40,8 +40,12 @@ VPATH += $(SRCDIR) > > > > ifeq ($(RTE_BUILD_SHARED_LIB),y) > > LIB := $(patsubst %.a,%.so,$(LIB)) > > + > > +CPU_LDFLAGS += --version-script=$(EXPORT_MAP) > > What about setting --version-script=$(SRCDIR)/$(EXPORT_MAP) so we can do: > Ie. 'EXPORT_MAP = rte_eal_version.map' instead of 'EXPORT_MAP = $(RTE_SDK)/lib/librte_eal/linuxapp/eal/rte_eal_version.map' > > > + > > endif > > > > + > > _BUILD = $(LIB) > > _INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) > > $(RTE_OUTPUT)/lib/$(LIB) _CLEAN = doclean @@ -161,7 +165,9 @@ endif > > $(RTE_OUTPUT)/lib/$(LIB): $(LIB) > > @echo " INSTALL-LIB $(LIB)" > > @[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib > > +ifneq ($(LIB),) > > $(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib > > +endif > > > We could move the ifneq($(LIB),) to the _INSTALL variable (top of the same file). > Something like this: > > -_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/lib/$(LIB) > +_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) > +ifneq ($(LIB),) > +_INSTALL += $(RTE_OUTPUT)/lib/$(LIB) > +endif > Yeah, this all seems reasonable, I'll repost shortly Thanks Neil > Thanks, > Sergio > > > # > > # Clean all generated files > > -- > > 1.9.3 > >
next prev parent reply other threads:[~2014-12-22 16:22 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-20 21:01 [dpdk-dev] Add DSO symbol versioning to supportbackwards compatibility Neil Horman 2014-12-20 21:01 ` [dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning Neil Horman 2014-12-22 14:01 ` Gonzalez Monroy, Sergio 2014-12-22 16:22 ` Neil Horman [this message] 2014-12-22 16:34 ` Neil Horman 2014-12-22 17:09 ` Gonzalez Monroy, Sergio 2014-12-22 19:00 ` Neil Horman 2014-12-22 20:04 ` Neil Horman 2014-12-20 21:01 ` [dpdk-dev] [PATCH 2/4] Provide initial versioning for all DPDK libraries Neil Horman 2014-12-20 21:01 ` [dpdk-dev] [PATCH 3/4] Add library version extenstion Neil Horman 2014-12-20 21:01 ` [dpdk-dev] [PATCH 4/4] docs: Add ABI documentation Neil Horman 2014-12-22 20:24 ` [dpdk-dev] [PATCH v2 1/4] compat: Add infrastructure to support symbol versioning Neil Horman 2014-12-22 20:24 ` [dpdk-dev] [PATCH v2 2/4] Provide initial versioning for all DPDK libraries Neil Horman 2014-12-22 20:24 ` [dpdk-dev] [PATCH v2 3/4] Add library version extenstion Neil Horman 2014-12-23 13:05 ` Gonzalez Monroy, Sergio 2014-12-23 15:50 ` Neil Horman 2014-12-22 20:24 ` [dpdk-dev] [PATCH v2 4/4] docs: Add ABI documentation Neil Horman 2014-12-23 9:48 ` Iremonger, Bernard 2014-12-23 13:01 ` Neil Horman 2014-12-23 13:27 ` [dpdk-dev] [PATCH v2 1/4] compat: Add infrastructure to support symbol versioning Gonzalez Monroy, Sergio 2014-12-23 15:50 ` Neil Horman 2014-12-23 15:51 ` [dpdk-dev] [PATCH v3 " Neil Horman 2014-12-23 15:51 ` [dpdk-dev] [PATCH v3 2/4] Provide initial versioning for all DPDK libraries Neil Horman 2014-12-29 16:21 ` Sergio Gonzalez Monroy 2015-01-14 15:29 ` Thomas Monjalon 2015-01-14 16:24 ` Neil Horman 2014-12-23 15:51 ` [dpdk-dev] [PATCH v3 3/4] Add library version extenstion Neil Horman 2014-12-23 16:44 ` Gonzalez Monroy, Sergio 2014-12-23 17:08 ` Neil Horman 2014-12-29 16:23 ` Sergio Gonzalez Monroy 2015-01-14 15:48 ` Thomas Monjalon 2014-12-23 15:51 ` [dpdk-dev] [PATCH v3 4/4] docs: Add ABI documentation Neil Horman 2014-12-29 16:24 ` Sergio Gonzalez Monroy 2015-01-14 15:59 ` Thomas Monjalon 2015-01-14 20:07 ` Neil Horman 2015-01-16 13:34 ` Thomas Monjalon 2014-12-29 16:20 ` [dpdk-dev] [PATCH v3 1/4] compat: Add infrastructure to support symbol versioning Sergio Gonzalez Monroy 2015-01-14 15:25 ` Thomas Monjalon 2015-01-14 20:29 ` Neil Horman 2015-01-09 12:35 ` [dpdk-dev] Add DSO symbol versioning to supportbackwards compatibility Neil Horman 2015-01-15 19:35 ` [dpdk-dev] [PATCH v4 1/4] compat: Add infrastructure to support symbol versioning Neil Horman 2015-01-15 19:35 ` [dpdk-dev] [PATCH v4 2/4] Provide initial versioning for all DPDK libraries Neil Horman 2015-01-15 19:35 ` [dpdk-dev] [PATCH v4 3/4] Add library version extenstion Neil Horman 2015-01-15 19:35 ` [dpdk-dev] [PATCH v4 4/4] docs: Add ABI documentation Neil Horman 2015-01-30 17:13 ` [dpdk-dev] [PATCH v4 1/4] compat: Add infrastructure to support symbol versioning Gray, Mark D 2015-01-16 15:33 ` [dpdk-dev] [PATCH v5 " Neil Horman 2015-01-16 15:33 ` [dpdk-dev] [PATCH v5 2/4] Provide initial versioning for all DPDK libraries Neil Horman 2015-01-16 15:33 ` [dpdk-dev] [PATCH v5 3/4] Add library version extenstion Neil Horman 2015-01-16 15:33 ` [dpdk-dev] [PATCH v5 4/4] docs: Add ABI documentation Neil Horman 2015-01-20 7:14 ` Thomas Monjalon 2015-01-20 10:47 ` Bruce Richardson 2015-01-20 13:37 ` Iremonger, Bernard 2015-01-20 13:46 ` Thomas Monjalon 2015-01-20 14:24 ` Neil Horman 2015-01-20 14:29 ` Butler, Siobhan A 2015-01-20 14:41 ` Neil Horman 2015-01-20 14:50 ` Butler, Siobhan A 2015-01-20 15:30 ` Neil Horman 2015-01-20 14:32 ` O'driscoll, Tim 2015-01-20 14:00 ` Thomas Monjalon 2015-01-20 14:37 ` Neil Horman 2015-01-20 15:06 ` Thomas Monjalon 2015-01-20 15:35 ` Neil Horman 2015-01-20 21:17 ` [dpdk-dev] [PATCH v6 1/4] compat: Add infrastructure to support symbol versioning Neil Horman 2015-01-20 21:17 ` [dpdk-dev] [PATCH v6 2/4] Provide initial versioning for all DPDK libraries Neil Horman 2015-01-20 21:17 ` [dpdk-dev] [PATCH v6 3/4] Add library version extenstion Neil Horman 2015-01-20 21:17 ` [dpdk-dev] [PATCH v6 4/4] docs: Add ABI documentation Neil Horman 2015-01-21 10:13 ` Iremonger, Bernard 2015-01-21 10:25 ` Thomas Monjalon 2015-01-21 14:59 ` Neil Horman 2015-01-21 16:05 ` Thomas Monjalon 2015-01-21 19:43 ` Neil Horman 2015-01-21 22:24 ` Thomas Monjalon 2015-01-22 19:21 ` Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 01/26] version: 2.0.0-rc0 Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 02/26] mk: fix link to static combined library Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 03/26] eal: fix check for power of 2 in 0 case Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 04/26] ethdev: fix missing parenthesis in mac check Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 05/26] mem: search only dpdk hugetlbfs maps Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 06/26] log: remove unnecessary stubs Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 07/26] vfio: avoid enabling while the module is not loaded Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 08/26] bond: fix vlan flag interpretation Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 09/26] app/testpmd: remove duplicated function for list parsing Neil Horman 2015-01-21 20:57 ` [dpdk-dev] [PATCH v7 10/26] nic_uio: fix thread structure compatibility for future FreeBSD Neil Horman 2015-01-21 20:58 ` [dpdk-dev] [PATCH v7 01/26] version: 2.0.0-rc0 Neil Horman 2015-01-21 20:59 ` [dpdk-dev] [PATCH v7 1/4] compat: Add infrastructure to support symbol versioning Neil Horman 2015-01-21 20:59 ` [dpdk-dev] [PATCH v7 2/4] Provide initial versioning for all DPDK libraries Neil Horman 2015-01-21 20:59 ` [dpdk-dev] [PATCH v7 3/4] Add library version extenstion Neil Horman 2015-01-21 20:59 ` [dpdk-dev] [PATCH v7 4/4] docs: Add ABI documentation Neil Horman 2015-01-22 10:56 ` Iremonger, Bernard 2015-01-22 15:37 ` Neil Horman 2015-01-22 15:49 ` [dpdk-dev] [PATCH v8 1/4] compat: Add infrastructure to support symbol versioning Neil Horman 2015-01-22 15:49 ` [dpdk-dev] [PATCH v8 2/4] Provide initial versioning for all DPDK libraries Neil Horman 2015-01-22 15:49 ` [dpdk-dev] [PATCH v8 3/4] Add library version extenstion Neil Horman 2015-01-22 15:49 ` [dpdk-dev] [PATCH v8 4/4] docs: Add ABI documentation Neil Horman 2015-01-22 16:46 ` Butler, Siobhan A [not found] ` <1422898822-16422-1-git-send-email-nhorman@tuxdriver.com> [not found] ` <1422898822-16422-4-git-send-email-nhorman@tuxdriver.com> 2015-02-03 15:24 ` [dpdk-dev] [PATCH v9 " Thomas Monjalon 2015-02-03 16:01 ` [dpdk-dev] Add DSO symbol versioning to supportbackwards compatibility Thomas Monjalon 2015-02-03 20:20 ` Neil Horman -- strict thread matches above, loose matches on Subject: below -- 2014-09-15 19:23 [dpdk-dev] [PATCH 0/4] Add DSO symbol versioning to support backwards compatibility Neil Horman 2014-09-15 19:23 ` [dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning Neil Horman 2014-09-23 10:39 ` Sergio Gonzalez Monroy 2014-09-23 14:58 ` Neil Horman 2014-09-23 16:29 ` Sergio Gonzalez Monroy 2014-09-23 17:31 ` Neil Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20141222162227.GC26669@hmsreliant.think-freely.org \ --to=nhorman@tuxdriver.com \ --cc=dev@dpdk.org \ --cc=sergio.gonzalez.monroy@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git