From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 908B3960F for ; Mon, 22 Dec 2014 17:34:58 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Y35wc-0005aA-EN; Mon, 22 Dec 2014 11:34:56 -0500 Date: Mon, 22 Dec 2014 11:34:53 -0500 From: Neil Horman To: "Gonzalez Monroy, Sergio" Message-ID: <20141222163453.GD26669@hmsreliant.think-freely.org> References: <1419109299-9603-1-git-send-email-nhorman@tuxdriver.com> <1419109299-9603-2-git-send-email-nhorman@tuxdriver.com> <91383E96CE459D47BCE92EFBF5CE73B004F20D71@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F20D71@IRSMSX108.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Dec 2014 16:34:58 -0000 On Mon, Dec 22, 2014 at 02:01:10PM +0000, Gonzalez Monroy, Sergio wrote: > Hi Neil, > > Just a couple of minor comments. > > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > Sent: Saturday, December 20, 2014 9:02 PM > > Subject: [PATCH 1/4] compat: Add infrastructure to support symbol > > versioning > > > > Add initial pass header files to support symbol versioning. > > > [...] > > > > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 81bf8e1..2299cbe 100644 > > --- a/mk/rte.lib.mk > > +++ b/mk/rte.lib.mk > > @@ -40,8 +40,12 @@ VPATH += $(SRCDIR) > > > > ifeq ($(RTE_BUILD_SHARED_LIB),y) > > LIB := $(patsubst %.a,%.so,$(LIB)) > > + > > +CPU_LDFLAGS += --version-script=$(EXPORT_MAP) > > What about setting --version-script=$(SRCDIR)/$(EXPORT_MAP) so we can do: > Ie. 'EXPORT_MAP = rte_eal_version.map' instead of 'EXPORT_MAP = $(RTE_SDK)/lib/librte_eal/linuxapp/eal/rte_eal_version.map' > > > + > > endif > > > > + > > _BUILD = $(LIB) > > _INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) > > $(RTE_OUTPUT)/lib/$(LIB) _CLEAN = doclean @@ -161,7 +165,9 @@ endif > > $(RTE_OUTPUT)/lib/$(LIB): $(LIB) > > @echo " INSTALL-LIB $(LIB)" > > @[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib > > +ifneq ($(LIB),) > > $(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib > > +endif > > > We could move the ifneq($(LIB),) to the _INSTALL variable (top of the same file). > Something like this: > > -_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/lib/$(LIB) > +_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) > +ifneq ($(LIB),) > +_INSTALL += $(RTE_OUTPUT)/lib/$(LIB) > +endif > Actually, as I look at it, this second one doesn't seem to make any sense to me. _INSTALL as a variable doesn't seem to get used anywhere that I can see, certainly not in the capacity of copying shared libraries into the build/lib area so that the example apps can get linked with them. So I'm not sure this makes sense. Neil > Thanks, > Sergio > > > # > > # Clean all generated files > > -- > > 1.9.3 > >