From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 351CA963C for ; Mon, 22 Dec 2014 20:00:23 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Y38DK-00022Z-Ns; Mon, 22 Dec 2014 14:00:20 -0500 Date: Mon, 22 Dec 2014 14:00:17 -0500 From: Neil Horman To: "Gonzalez Monroy, Sergio" Message-ID: <20141222190017.GF26669@hmsreliant.think-freely.org> References: <1419109299-9603-1-git-send-email-nhorman@tuxdriver.com> <1419109299-9603-2-git-send-email-nhorman@tuxdriver.com> <91383E96CE459D47BCE92EFBF5CE73B004F20D71@IRSMSX108.ger.corp.intel.com> <20141222163453.GD26669@hmsreliant.think-freely.org> <91383E96CE459D47BCE92EFBF5CE73B004F20DD4@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F20DD4@IRSMSX108.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Dec 2014 19:00:23 -0000 On Mon, Dec 22, 2014 at 05:09:55PM +0000, Gonzalez Monroy, Sergio wrote: > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > Sent: Monday, December 22, 2014 4:35 PM > > > > On Mon, Dec 22, 2014 at 02:01:10PM +0000, Gonzalez Monroy, Sergio wrote: > > > > > > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > > > Sent: Saturday, December 20, 2014 9:02 PM > > > We could move the ifneq($(LIB),) to the _INSTALL variable (top of the same > > file). > > > Something like this: > > > > > > -_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) > > > $(RTE_OUTPUT)/lib/$(LIB) > > > +_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) ifneq ($(LIB),) > > > +_INSTALL += $(RTE_OUTPUT)/lib/$(LIB) endif > > > > > Actually, as I look at it, this second one doesn't seem to make any sense to > > me. > > _INSTALL as a variable doesn't seem to get used anywhere that I can see, > > certainly not in the capacity of copying shared libraries into the build/lib area > > so that the example apps can get linked with them. So I'm not sure this > > makes sense. > > > The _INSTALL var gets expanded for the rule '_install' in mk/internal/rte.install-post.mk if I am not mistaken. > That would trigger the rule $(RTE_OUTPUT)/lib/$(LIB) which in turn builds and copy the shared/static library to build/lib. > > If we do not add $(RTE_OUTPUT)/lib/$(LIB) to _INSTALL, then the rule will not trigger. > I get all of that, but something isn't right with either your reasoning, or my coding, as If I make the change you suggest, nothing ever gets copied into the build/lib directory, either for a static or DSO build. Neil > Regards, > Sergio > > > Neil > > >