From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 8221B7DF7
 for <dev@dpdk.org>; Thu, 25 Dec 2014 18:41:51 +0100 (CET)
Received: from [2001:470:8:a08:215:ff:fecc:4872] (helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1Y4CQ0-000502-Af; Thu, 25 Dec 2014 12:41:50 -0500
Date: Thu, 25 Dec 2014 12:41:46 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Ravi Kerur <rkerur@gmail.com>
Message-ID: <20141225174146.GE3199@localhost.localdomain>
References: <1419521597-31978-1-git-send-email-rkerur@gmail.com>
 <1419521597-31978-4-git-send-email-rkerur@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1419521597-31978-4-git-send-email-rkerur@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/7] Move EAL common functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Dec 2014 17:41:51 -0000

On Thu, Dec 25, 2014 at 10:33:13AM -0500, Ravi Kerur wrote:
> eal_thread.c has minor difference between Linux and BSD, move
> into common directory.
> Use RTE_EXEC_ENV_BSDAPP to differentiate minor difference.
> Rename eal_thread.c to eal_common_thread.c
> Makefile changes to reflect file move and name change.
> Fix checkpatch warnings.
> 
Don't you want to add RTE_EXEC_ENV_BSDAPP=y to config/common_bsdapp?

Neil