From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 272E72EDA for ; Sun, 28 Dec 2014 04:49:11 +0100 (CET) Received: from [2001:470:8:a08:215:ff:fecc:4872] (helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Y54qc-0004HX-Pf; Sat, 27 Dec 2014 22:49:04 -0500 Date: Sat, 27 Dec 2014 22:48:52 -0500 From: Neil Horman To: Stephen Hemminger Message-ID: <20141228034852.GA18713@localhost.localdomain> References: <20141227151300.7b62f5bf@urahara> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141227151300.7b62f5bf@urahara> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] resolve conflict between net/ethernet.h and rte_ethdev.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2014 03:49:11 -0000 On Sat, Dec 27, 2014 at 03:13:00PM -0800, Stephen Hemminger wrote: > This is a patch to address the conflict between > and the definitions in . It has two side effects > worth discussion: > 1. It forces inclusion of net/ethernet.h > 2. It has definition to deal with the differing structure elements > in the two versions of struct ether_addr. > > By doing this ether_ntoa and related functions can be used without > messing with prototypes. > > Alternative is more complex #ifdef magic like linux/libc-compat.h > > This seems like a reasonable fix for the problem, and nasty compat-work Acked-by: Neil Horman