From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4008C5963 for ; Mon, 5 Jan 2015 13:11:19 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 05 Jan 2015 04:08:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="507541960" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.27]) by orsmga003.jf.intel.com with SMTP; 05 Jan 2015 04:05:42 -0800 Received: by (sSMTP sendmail emulation); Mon, 05 Jan 2015 12:11:16 +0025 Date: Mon, 5 Jan 2015 12:11:16 +0000 From: Bruce Richardson To: Ravi Kerur Message-ID: <20150105121115.GF13152@bricha3-MOBL3> References: <1419521508-31883-1-git-send-email-rkerur@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1419521508-31883-1-git-send-email-rkerur@gmail.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2] Fix checkpatch errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 12:11:19 -0000 On Thu, Dec 25, 2014 at 10:31:46AM -0500, Ravi Kerur wrote: > checkpatch script is run against files in librte_acl and > librte_mempool files. No functionality change. > Changes are tested in Ubuntu and FreeBSD. > > Ravi Kerur (2): > Fix checkpatch errors in librte_acl > Fix checkpatch errors in librte_mempool > There are quite a lot of changes in these patches for fixing style errors. While you do call out what errors are treated as false positives, i.e. are not fixed, I think the description also needs to call out what the main errors were that were fixed, so that we can understand better why each chunk of code change was made. Regards, /Bruce