From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 816C75921 for ; Mon, 5 Jan 2015 13:24:20 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 05 Jan 2015 04:21:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,698,1413270000"; d="scan'208";a="664534673" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.27]) by orsmga002.jf.intel.com with SMTP; 05 Jan 2015 04:24:17 -0800 Received: by (sSMTP sendmail emulation); Mon, 05 Jan 2015 12:24:16 +0025 Date: Mon, 5 Jan 2015 12:24:16 +0000 From: Bruce Richardson To: Ravi Kerur Message-ID: <20150105122416.GG13152@bricha3-MOBL3> References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> <54A11509.5050904@6wind.com> <20141229124723.GA27775@localhost.localdomain> <54A15420.2010401@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/7] Move EAL common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 12:24:20 -0000 On Sun, Jan 04, 2015 at 03:10:46PM -0800, Ravi Kerur wrote: > Hi, > > I plan to work on this and would like to know if I need consider anything > else other than mentioned in the email by Olivier/Neil i.e.go with 2 > directories > > common-os/generic-os > common-posix > > under librte_eal directory and move relevant files accordingly. > > Thanks, > Ravi > Hopefully that means two directories, not three. I think the existing common folder should stay as it is, with the same name, and possibly add one new folder for code that is common between BSD and Linux, but which would not be common to other non-unix environments. I would be in favour of "common-posix" or "common-unix" for such a folder name, if one is created. In the absense of any other supported OS (or baremetal), I wonder as to the value of creating such a separation at this point? /Bruce > On Mon, Dec 29, 2014 at 10:43 AM, Ravi Kerur wrote: > > > Thanks Olivier and Neil. I will make a note on this and will work on it > > after initial common code movement is completed. > > > > > > On Mon, Dec 29, 2014 at 5:16 AM, Olivier MATZ > > wrote: > > > >> Hi Neil, > >> > >> On 12/29/2014 01:47 PM, Neil Horman wrote: > >> > On Mon, Dec 29, 2014 at 09:47:05AM +0100, Olivier MATZ wrote: > >> >> Trying to factorize the common code goes in the good direction. > >> >> > >> >> However I'm wondering if "common" is the proper place. Initially, > >> >> the common directory was for code common to linuxapp and baremetal. > >> >> Now that baremetal does not exist anymore, a lot of code is common > >> >> to the 2 OSes that are supported (linux and FreeBSD). > >> >> > >> >> What about moving this code in "common-posix" instead? > >> >> It would let the door open for future ports (Windows? or any > >> >> other real time OS? Or back in baremetal?). > >> >> > >> > Posix doesn't make sense IMO, in that a large segment of the functions > >> embodied > >> > in the common directory have nothing to do with posix API's, and are > >> simply just > >> > useful functions that have not OS specific dependency (the entire > >> > eal_common_memory.c file for example, to name just one). > >> > > >> > If you wanted to rename the directory, I would say generic-os would be > >> more > >> > appropriate. > >> > >> That's probably right for most of the code in the patch. I just wanted > >> to point out that "common" is sometimes a bit vague (common to archs, > >> common to OSes, common to all). > >> > >> From a quick look, these 2 files could be concerned and could go to a > >> common-posix directory: > >> - eal.c (use fopen/ftruncate/fcntl/mmap/...) > >> - eal_thread.c (use pipe/read/write) > >> > >> There's no urgency to do that now and maybe we should wait it's really > >> needed. I was just seizing the opportunity as the code is moved. > >> > >> Regards, > >> Olivier > >> > > > >