From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id ADD0C58F7 for ; Wed, 14 Jan 2015 11:09:54 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 14 Jan 2015 02:04:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="440381726" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.69]) by FMSMGA003.fm.intel.com with SMTP; 14 Jan 2015 01:56:57 -0800 Received: by (sSMTP sendmail emulation); Wed, 14 Jan 2015 10:09:49 +0025 Date: Wed, 14 Jan 2015 10:09:49 +0000 From: Bruce Richardson To: "Ferriter, Cian" Message-ID: <20150114100946.GA10476@bricha3-MOBL3> References: <1421140920-9964-1-git-send-email-cian.ferriter@intel.com> <20150113135549.GA3460@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jan 2015 10:09:55 -0000 On Tue, Jan 13, 2015 at 06:05:25PM +0000, Ferriter, Cian wrote: > Comments on alternative solutions: > 1) how would this solution work when there is no NIC present, and "rte_eth_from_rings" is called? Here, could you have an else where the socket id of the master core is passed to the "memzone_reserve"? > 2) how would you advise making this change? I have looked at where "rte_eth_dev_allocate" is being called and in all but one case, there is a "numa_id" that could be passed in. This isn't the case for " rte_eth_dev_init" however, is there an easy solution for this? Would there now need to be an "rte_eth_dev_data" struct for each socket that there is a NIC attached to, reserving memory from that socket? > > Cian While I think the issues you highlight can probably be overcome, I'm not so sure any more how much it matters what numa node this is allocated on. The ethdev data for any port in use by a port should be in the cache. In that case, if it doesn't matter, your original suggestion would work fine. /Bruce > > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, January 13, 2015 1:56 PM > To: Ferriter, Cian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve > > On Tue, Jan 13, 2015 at 09:23:16AM +0000, Ferriter, Cian wrote: > > Passing a socket id of "rte_socket_id()" can cause problems in non DPDK applications as there is a dependency on the current logical core we are running on. > > Passing " rte_lcore_to_socket_id(rte_get_master_lcore())" as the socket id to rte_memzone_reserve resolves these issues as the master lcore doesn't change. > > > > The only trouble is that when affinitizing the memory for the NICs to the socket of the master lcore, it gives us no way to correctly configure an app to use NICs connected to two different sockets on the one system. All memory for all NICs will end up on the same socket. Two possible alternative solutions: > 1) affinitize memory to the socket the NIC is connected to > 2) add a socket parameter to the API calls to allow the user complete control over their memory allocations > > Obviously the second one breaks backward compatibility (assume we modify existing API call), but is more powerful. > > Thoughts? > > /Bruce > > > -----Original Message----- > > From: Ferriter, Cian > > Sent: Tuesday, January 13, 2015 9:22 AM > > To: dev@dpdk.org > > Cc: Ferriter, Cian > > Subject: [PATCH] lib/librte_ether: change socket_id passed to > > rte_memzone_reserve > > > > Change the socket id that is passed to rte_memzone_reserve from the socket id of current logical core to the socket id of the master_lcore. > > --- > > lib/librte_ether/rte_ethdev.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) mode change 100644 > > => 100755 lib/librte_ether/rte_ethdev.c > > > > diff --git a/lib/librte_ether/rte_ethdev.c > > b/lib/librte_ether/rte_ethdev.c old mode 100644 new mode 100755 index > > 95f2ceb..835540d > > --- a/lib/librte_ether/rte_ethdev.c > > +++ b/lib/librte_ether/rte_ethdev.c > > @@ -184,7 +184,7 @@ rte_eth_dev_data_alloc(void) > > if (rte_eal_process_type() == RTE_PROC_PRIMARY){ > > mz = rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA, > > RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data), > > - rte_socket_id(), flags); > > + rte_lcore_to_socket_id(rte_get_master_lcore()), flags); > > } else > > mz = rte_memzone_lookup(MZ_RTE_ETH_DEV_DATA); > > if (mz == NULL) > > -- > > 1.7.4.1 > >