From: Bruce Richardson <bruce.richardson@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets.
Date: Fri, 16 Jan 2015 10:52:55 +0000 [thread overview]
Message-ID: <20150116105255.GA10516@bricha3-MOBL3> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258213D5104@irsmsx105.ger.corp.intel.com>
On Thu, Jan 15, 2015 at 11:54:52PM +0000, Ananyev, Konstantin wrote:
> Hi,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur
> > Sent: Thursday, January 15, 2015 8:34 PM
> > To: Thomas Monjalon
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets.
> >
> > On Wed, Jan 14, 2015 at 8:27 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
> > wrote:
> >
> > > 2015-01-09 04:41, Ravi Kerur:
> > > > Thomas,
> > > >
> > > > Please let me know how I can move forward on this. If i confine changes
> > > in
> > > > e1000/ directory to e1000_osdep.h file only and the rest in PMD will that
> > > > work? The reason I ask is because of following comment in README file.
> > > >
> > > > ...
> > > > Few changes to the original FreeBSD sources were made to:
> > > > - Adopt it for PMD usage mode:
> > > > e1000_osdep.c
> > > > e1000_osdep.h
> > > > ...
>
> Yes, if needed you can modify these files.
> In fact, these files are the only 2 that are allowed to be modified inside e1000 sub-directory.
> As I understand you plan to implement E1000_READ_FLASH_REG and E1000_WRITE_FLASH_REG
> macros properly, correct?
> Konstantin
>
As a cleanup we should really look to move these two files out of the e1000
subdirectory (and similarly for the ixgbe versions etc.), so as to give a cleaner
and more manageable separation between what can be edited or not.
/Bruce
next prev parent reply other threads:[~2015-01-16 10:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 23:28 Ravi Kerur
2015-01-05 8:55 ` Thomas Monjalon
2015-01-05 16:40 ` Ravi Kerur
2015-01-09 12:41 ` Ravi Kerur
2015-01-14 16:27 ` Thomas Monjalon
2015-01-15 20:34 ` Ravi Kerur
2015-01-15 21:22 ` O'driscoll, Tim
2015-01-15 23:54 ` Ananyev, Konstantin
2015-01-16 10:52 ` Bruce Richardson [this message]
2015-01-16 11:08 ` Ananyev, Konstantin
2015-01-16 11:31 ` Bruce Richardson
2015-01-16 12:01 ` Ananyev, Konstantin
2015-01-22 0:03 ` Ravi Kerur
2015-01-16 1:14 ` Zhang, Helin
2015-01-16 1:43 ` Ravi Kerur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116105255.GA10516@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).