From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 22CBB5A3D
 for <dev@dpdk.org>; Fri, 16 Jan 2015 11:53:09 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga103.fm.intel.com with ESMTP; 16 Jan 2015 02:47:46 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,410,1418112000"; d="scan'208";a="638276376"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.34])
 by orsmga001.jf.intel.com with SMTP; 16 Jan 2015 02:52:59 -0800
Received: by  (sSMTP sendmail emulation); Fri, 16 Jan 2015 10:52:55 +0025
Date: Fri, 16 Jan 2015 10:52:55 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Message-ID: <20150116105255.GA10516@bricha3-MOBL3>
References: <CAFb4SLBH4SJ2kL-JeCziXMtiG-g+F3b6wQ__6fSjsTWq7LzO3A@mail.gmail.com>
 <CAFb4SLAvUiiDHuevRK5Qk_GYCii7LqfOAr+ADw9ezxdEcq_QRg@mail.gmail.com>
 <CAFb4SLCr-JF9LGXF_rmW-cEHEjPkh_pP-e1kcTO0h8wQWbMvVA@mail.gmail.com>
 <3180122.JKDOmAPjoA@xps13>
 <CAFb4SLDs3wVDpOOLtH3Lg1h3+c8ZpzgKZUz3MMO17Akqoc1B9Q@mail.gmail.com>
 <2601191342CEEE43887BDE71AB977258213D5104@irsmsx105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2601191342CEEE43887BDE71AB977258213D5104@irsmsx105.ger.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jan 2015 10:53:10 -0000

On Thu, Jan 15, 2015 at 11:54:52PM +0000, Ananyev, Konstantin wrote:
> Hi,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur
> > Sent: Thursday, January 15, 2015 8:34 PM
> > To: Thomas Monjalon
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets.
> > 
> > On Wed, Jan 14, 2015 at 8:27 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
> > wrote:
> > 
> > > 2015-01-09 04:41, Ravi Kerur:
> > > > Thomas,
> > > >
> > > > Please let me know how I can move forward on this. If i confine changes
> > > in
> > > > e1000/ directory to e1000_osdep.h file only and the rest in PMD will that
> > > > work? The reason I ask is because of following comment  in README file.
> > > >
> > > > ...
> > > > Few changes to the original FreeBSD sources were made to:
> > > > - Adopt it for PMD usage mode:
> > > >         e1000_osdep.c
> > > >         e1000_osdep.h
> > > > ...
> 
> Yes, if needed you can modify these files.
> In fact, these files are the only 2 that are allowed to be modified inside e1000 sub-directory.
> As I understand you plan to implement E1000_READ_FLASH_REG  and E1000_WRITE_FLASH_REG
> macros properly, correct?
> Konstantin
> 

As a cleanup we should really look to move these two files out of the e1000
subdirectory (and similarly for the ixgbe versions etc.), so as to give a cleaner
and more manageable separation between what can be edited or not.

/Bruce