From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 13FB25424 for ; Mon, 19 Jan 2015 17:33:12 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YDFGG-0008P1-Hk; Mon, 19 Jan 2015 11:33:10 -0500 Date: Mon, 19 Jan 2015 11:33:06 -0500 From: Neil Horman To: Helin Zhang Message-ID: <20150119163306.GD21790@hmsreliant.think-freely.org> References: <1421637803-17034-1-git-send-email-helin.zhang@intel.com> <1421637803-17034-2-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1421637803-17034-2-git-send-email-helin.zhang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC 01/17] mbuf: add definitions of unified packet types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2015 16:33:12 -0000 On Mon, Jan 19, 2015 at 11:23:07AM +0800, Helin Zhang wrote: > As there are only 6 bit flags in ol_flags for indicating packet types, > which is not enough to describe all the possible packet types hardware > can recognize. For example, i40e hardware can recognize more than 150 > packet types. Unified packet type is composed of tunnel type, L3 type, > L4 type and inner L3 type fields, and can be stored in 16 bits mbuf > field of 'packet_type'. > > Signed-off-by: Helin Zhang > Signed-off-by: Cunming Liang > Signed-off-by: Jijiang Liu > --- > lib/librte_mbuf/rte_mbuf.h | 68 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 16059c6..94eb38f 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -165,6 +165,74 @@ extern "C" { > /* Use final bit of flags to indicate a control mbuf */ > #define CTRL_MBUF_FLAG (1ULL << 63) /**< Mbuf contains control data */ > > +/* > + * Sixteen bits are divided into several fields to mark packet types. Note that > + * each field is indexical. > + * - Bit 3:0 is for tunnel types. > + * - Bit 7:4 is for L3 or outer L3 (for tunneling case) types. > + * - Bit 10:8 is for L4 types. It can also be used for inner L4 types for > + * tunneling packets. This seems a bit sparse, in that the protocol field is 8 bits wide in a packet. There are several common protocls that you don't have listed, and you've already exhausted your namespace with the list you have. Neil