From: Neil Horman <nhorman@tuxdriver.com>
To: stephen@networkplumber.org
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH] stats: remove useless memset's
Date: Wed, 21 Jan 2015 07:43:59 -0500 [thread overview]
Message-ID: <20150121124359.GD18515@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1421813818-2354-1-git-send-email-stephen@networkplumber.org>
On Tue, Jan 20, 2015 at 08:16:58PM -0800, stephen@networkplumber.org wrote:
> From: Stephen Hemminger <shemming@brocade.com>
>
> The rte_eth_stats_get is the only API that should call the device
> statistics function directly, and it already does a memset of the
> resulting structure. Therefore doing memset() in the driver is
> redundant and should be removed.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2015-01-21 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 4:16 stephen
2015-01-21 12:43 ` Neil Horman [this message]
2015-01-21 13:08 ` David Marchand
2015-01-27 12:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121124359.GD18515@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).