From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id D21345A1F for ; Wed, 21 Jan 2015 13:44:06 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YDudd-0001WA-E1; Wed, 21 Jan 2015 07:44:04 -0500 Date: Wed, 21 Jan 2015 07:43:59 -0500 From: Neil Horman To: stephen@networkplumber.org Message-ID: <20150121124359.GD18515@hmsreliant.think-freely.org> References: <1421813818-2354-1-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1421813818-2354-1-git-send-email-stephen@networkplumber.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH] stats: remove useless memset's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 12:44:07 -0000 On Tue, Jan 20, 2015 at 08:16:58PM -0800, stephen@networkplumber.org wrote: > From: Stephen Hemminger > > The rte_eth_stats_get is the only API that should call the device > statistics function directly, and it already does a memset of the > resulting structure. Therefore doing memset() in the driver is > redundant and should be removed. > > Signed-off-by: Stephen Hemminger Acked-by: Neil Horman