From: Dan Aloni <dan@kernelim.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/linux: allow to map BARs with MSI-X tables, around them
Date: Thu, 29 Jan 2015 00:04:43 +0200 [thread overview]
Message-ID: <20150128220443.GA2426@gmail.com> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E4512369780C3ECFA@IRSMSX109.ger.corp.intel.com>
On Wed, Jan 28, 2015 at 03:01:38PM +0000, Burakov, Anatoly wrote:
> Hi Dan
>
> Apologies for not looking at it earlier.
No problem, we are all quite busy :)
> > + if (map_addr != MAP_FAILED
> > + && memreg[1].offset && memreg[1].size) {
> > + uint8_t *second_addr =
> > + ((uint8_t *)bar_addr +
> > memreg[1].offset);
>
> Nitpicking, but probably better to use void* and RTE_PTR_ADD here.
Nitpicking very justified. New patch coming your way.
--
Dan Aloni
next prev parent reply other threads:[~2015-01-28 22:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 8:36 Dan Aloni
2015-01-28 14:06 ` Dan Aloni
2015-01-28 15:01 ` Burakov, Anatoly
2015-01-28 22:04 ` Dan Aloni [this message]
2015-01-28 22:04 ` [dpdk-dev] [PATCH v2] " Dan Aloni
2015-01-29 10:22 ` Burakov, Anatoly
2015-01-29 10:25 ` Dan Aloni
2015-02-23 20:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128220443.GA2426@gmail.com \
--to=dan@kernelim.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).