DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, KY Srinivasan <kys@microsoft.com>,
	Stephen Hemminger <shemming@Brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/7] ether: add function to query for link state interrupt
Date: Wed, 4 Feb 2015 21:49:07 -0800	[thread overview]
Message-ID: <20150204214907.6527b1b1@urahara> (raw)
In-Reply-To: <2d9df6f5729c42a9a2b85a20b7316243@BRMWP-EXMB11.corp.brocade.com>

On Thu, 5 Feb 2015 01:47:37 +0000
Neil Horman <nhorman@tuxdriver.com> wrote:

> On Wed, Feb 04, 2015 at 05:13:23PM -0800, Stephen Hemminger wrote:
> > From: Stephen Hemminger <shemming@brocade.com>
> > 
> > Allow application to query whether link state will work.
> > This is also part of abstracting dependency on PCI.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  lib/librte_ether/rte_ethdev.c | 14 ++++++++++++++
> >  lib/librte_ether/rte_ethdev.h | 12 ++++++++++++
> >  2 files changed, 26 insertions(+)
> > 
> > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> > index ea3a1fb..4d803d0 100644
> > --- a/lib/librte_ether/rte_ethdev.c
> > +++ b/lib/librte_ether/rte_ethdev.c
> > @@ -1264,6 +1264,20 @@ rte_eth_link_get_nowait(uint8_t port_id, struct rte_eth_link *eth_link)
> >  	}
> >  }
> >  
> > +int
> > +rte_eth_has_link_state(uint8_t port_id)
> > +{
> > +	struct rte_eth_dev *dev;
> > +
> > +	if (port_id >= nb_ports) {
> > +		PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> > +		return 0;
> > +	}
> > +	dev = &rte_eth_devices[port_id];
> > +
> > +	return (dev->pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC) != 0;
> > +}
> > +
> >  void
> >  rte_eth_stats_get(uint8_t port_id, struct rte_eth_stats *stats)
> >  {
> > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> > index 1200c1c..9d43ca3 100644
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > @@ -2038,6 +2038,18 @@ extern void rte_eth_link_get_nowait(uint8_t port_id,
> >  				struct rte_eth_link *link);
> >  
> >  /**
> > + * Test whether device supports link state interrupt mode.
> > + *
> > + * @param port_id
> > + *   The port identifier of the Ethernet device.
> > + * @return
> > + *   - (1) if link state interrupt is supported
> > + *   - (0) if link state interrupt is not supported
> > + */
> > +extern int
> > +rte_eth_has_link_state(uint8_t port_id);
> > +
> > +/**
> >   * Retrieve the general I/O statistics of an Ethernet device.
> >   *
> >   * @param port_id
> > -- 
> > 2.1.4
> > 
> > 
> I think if your intention is to expose this as an application (or other library
> visible api), you'll need to add it to the appropriate version map file for the
> link now.  Should just be a single line addition
> 
> Regards
> Neil
> 

Will add that after other changes are approved.
Also looking at the map files they seem to have been auto generated
because some symbols are exposed which are unnecessary (example pci_driver_list)

  parent reply	other threads:[~2015-02-05  5:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05  1:13 [dpdk-dev] [PATCH 0/7] Hyper-v driver and infrastructure Stephen Hemminger
2015-02-05  1:13 ` [dpdk-dev] [PATCH 1/7] ether: add function to query for link state interrupt Stephen Hemminger
2015-02-05  1:47   ` Neil Horman
     [not found]   ` <2d9df6f5729c42a9a2b85a20b7316243@BRMWP-EXMB11.corp.brocade.com>
2015-02-05  5:49     ` Stephen Hemminger [this message]
2015-02-05 12:39       ` Neil Horman
2015-02-05  1:13 ` [dpdk-dev] [PATCH 2/7] pmd: change drivers initialization for pci Stephen Hemminger
2015-02-05  1:13 ` [dpdk-dev] [PATCH 3/7] hv: add basic vmbus support Stephen Hemminger
2015-02-05  1:50   ` Neil Horman
2015-02-05  1:13 ` [dpdk-dev] [PATCH 4/7] hv: uio driver Stephen Hemminger
2015-02-05  1:13 ` [dpdk-dev] [PATCH 5/7] hv: poll mode driver Stephen Hemminger
2015-02-05  1:13 ` [dpdk-dev] [PATCH 6/7] hv: enable driver in common config Stephen Hemminger
2015-02-05  1:13 ` [dpdk-dev] [PATCH 7/7] hv: add kernel patch Stephen Hemminger
2015-04-20 21:54 [dpdk-dev] [PATCH 0/7] Hyper-V Poll Mode Driver Stephen Hemminger
2015-04-20 21:54 ` [dpdk-dev] [PATCH 1/7] ether: add function to query for link state interrupt Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150204214907.6527b1b1@urahara \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=kys@microsoft.com \
    --cc=nhorman@tuxdriver.com \
    --cc=shemming@Brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).