From: Neil Horman <nhorman@tuxdriver.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/5] New Reorder Library
Date: Sun, 8 Feb 2015 08:58:33 -0500 [thread overview]
Message-ID: <20150208135833.GC12309@neilslaptop.think-freely.org> (raw)
In-Reply-To: <1423235164-3808-1-git-send-email-sergio.gonzalez.monroy@intel.com>
On Fri, Feb 06, 2015 at 03:05:59PM +0000, Sergio Gonzalez Monroy wrote:
> This series introduces the new reorder library along with unit tests,
> sample app and a new entry in the programmers guide describing the library.
>
> The library provides reordering of mbufs based on their sequence number.
>
> As mention in the patch describing the library, one use case is the
> packet distributor.
> The distributor receives packets, assigns them a sequence number and sends
> them to the workers.
> The workers process those packets and return them to the distributor.
> The distributor collects out-of-order packets from the workers and uses
> this library to reorder the packets based on the sequence number they
> were assigned.
>
> v3:
> - fix copyright date
> - add option to sample app to disable reordering
> - add packet ordering sample guide entry
>
> v2:
> - add programmers guide entry describing the library
> - use malloc instead of memzone to allocate memory
> - modify create and init implementation, init takes a reorder buffer as input
> and create reserves memory and call init.
> - update unit tests
>
> Sergio Gonzalez Monroy (5):
> reorder: new reorder library
> app: New reorder unit test
> examples: new sample app packet_ordering
> doc: new reorder library description
> doc: new packet ordering app description
>
> app/test/Makefile | 2 +
> app/test/test_reorder.c | 393 ++++++++++++++
> config/common_bsdapp | 5 +
> config/common_linuxapp | 5 +
> doc/guides/prog_guide/index.rst | 1 +
> doc/guides/prog_guide/reorder_lib.rst | 115 ++++
> doc/guides/sample_app_ug/index.rst | 1 +
> doc/guides/sample_app_ug/packet_ordering.rst | 102 ++++
> examples/packet_ordering/Makefile | 50 ++
> examples/packet_ordering/main.c | 695 +++++++++++++++++++++++++
> lib/Makefile | 1 +
> lib/librte_eal/common/include/rte_tailq_elem.h | 2 +
> lib/librte_mbuf/rte_mbuf.h | 3 +
> lib/librte_reorder/Makefile | 50 ++
> lib/librte_reorder/rte_reorder.c | 416 +++++++++++++++
> lib/librte_reorder/rte_reorder.h | 181 +++++++
> mk/rte.app.mk | 4 +
> 17 files changed, 2026 insertions(+)
> create mode 100644 app/test/test_reorder.c
> create mode 100644 doc/guides/prog_guide/reorder_lib.rst
> create mode 100644 doc/guides/sample_app_ug/packet_ordering.rst
> create mode 100644 examples/packet_ordering/Makefile
> create mode 100644 examples/packet_ordering/main.c
> create mode 100644 lib/librte_reorder/Makefile
> create mode 100644 lib/librte_reorder/rte_reorder.c
> create mode 100644 lib/librte_reorder/rte_reorder.h
>
> --
> 1.9.3
>
>
Functionally it looks pretty good. You need to define an export map and
LIBABIVER macro in your makefile though.
Neil
next prev parent reply other threads:[~2015-02-08 13:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 16:39 [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library Reshma Pattan
2015-01-07 16:39 ` [dpdk-dev] [PATCH 2/3] librte_reorder: New unit test cases added Reshma Pattan
2015-01-07 16:39 ` [dpdk-dev] [PATCH 3/3] librte_reorder: New sample app for reorder library Reshma Pattan
2015-01-07 17:45 ` [dpdk-dev] [PATCH 1/3] librte_reorder: New " Neil Horman
2015-01-08 14:41 ` Pattan, Reshma
2015-01-07 21:09 ` Richard Sanger
2015-01-08 16:28 ` Pattan, Reshma
2015-01-20 8:00 ` Thomas Monjalon
2015-01-29 17:35 ` Gonzalez Monroy, Sergio
2015-01-29 20:39 ` Neil Horman
2015-01-30 9:35 ` Gonzalez Monroy, Sergio
2015-01-30 13:14 ` [dpdk-dev] [PATCH v2 0/4] New Reorder Library Sergio Gonzalez Monroy
2015-01-30 13:14 ` [dpdk-dev] [PATCH v2 1/4] reorder: new reorder library Sergio Gonzalez Monroy
2015-01-30 13:14 ` [dpdk-dev] [PATCH v2 2/4] app: New reorder unit test Sergio Gonzalez Monroy
2015-01-30 13:14 ` [dpdk-dev] [PATCH v2 3/4] examples: new sample app packet_ordering Sergio Gonzalez Monroy
2015-01-30 13:14 ` [dpdk-dev] [PATCH v2 4/4] doc: new reorder library description Sergio Gonzalez Monroy
2015-02-06 15:05 ` [dpdk-dev] [PATCH v3 0/5] New Reorder Library Sergio Gonzalez Monroy
2015-02-06 15:06 ` [dpdk-dev] [PATCH v3 1/5] reorder: new reorder library Sergio Gonzalez Monroy
2015-02-06 15:06 ` [dpdk-dev] [PATCH v3 2/5] app: New reorder unit test Sergio Gonzalez Monroy
2015-02-06 15:06 ` [dpdk-dev] [PATCH v3 3/5] examples: new sample app packet_ordering Sergio Gonzalez Monroy
2015-02-06 15:06 ` [dpdk-dev] [PATCH v3 4/5] doc: new reorder library description Sergio Gonzalez Monroy
2015-02-06 15:06 ` [dpdk-dev] [PATCH v3 5/5] doc: new packet ordering app description Sergio Gonzalez Monroy
2015-02-08 13:58 ` Neil Horman [this message]
2015-02-11 11:17 ` [dpdk-dev] [PATCH v3 0/5] New Reorder Library Gonzalez Monroy, Sergio
2015-02-11 13:07 ` [dpdk-dev] [PATCH v4 " Sergio Gonzalez Monroy
2015-02-11 13:07 ` [dpdk-dev] [PATCH v4 1/5] reorder: new reorder library Sergio Gonzalez Monroy
2015-02-11 13:07 ` [dpdk-dev] [PATCH v4 2/5] app: New reorder unit test Sergio Gonzalez Monroy
2015-02-11 13:07 ` [dpdk-dev] [PATCH v4 3/5] examples: new sample app packet_ordering Sergio Gonzalez Monroy
2015-02-11 13:07 ` [dpdk-dev] [PATCH v4 4/5] doc: new reorder library description Sergio Gonzalez Monroy
2015-02-11 13:07 ` [dpdk-dev] [PATCH v4 5/5] doc: new packet ordering app description Sergio Gonzalez Monroy
2015-02-12 5:33 ` [dpdk-dev] [PATCH v4 0/5] New Reorder Library Neil Horman
2015-02-12 12:00 ` Declan Doherty
2015-02-18 14:22 ` Thomas Monjalon
2015-02-18 14:36 ` Gonzalez Monroy, Sergio
2015-02-18 14:58 ` [dpdk-dev] [PATCH v5 0/6] " Sergio Gonzalez Monroy
2015-02-18 14:58 ` [dpdk-dev] [PATCH v5 1/6] reorder: new reorder library Sergio Gonzalez Monroy
2015-02-19 9:20 ` Olivier MATZ
2015-02-19 9:50 ` Olivier MATZ
2015-02-18 14:58 ` [dpdk-dev] [PATCH v5 2/6] app: New reorder unit test Sergio Gonzalez Monroy
2015-02-18 14:58 ` [dpdk-dev] [PATCH v5 3/6] examples: new sample app packet_ordering Sergio Gonzalez Monroy
2015-02-18 14:58 ` [dpdk-dev] [PATCH v5 4/6] doc: new reorder library description Sergio Gonzalez Monroy
2015-02-18 14:58 ` [dpdk-dev] [PATCH v5 5/6] doc: new packet ordering app description Sergio Gonzalez Monroy
2015-02-18 14:58 ` [dpdk-dev] [PATCH v5 6/6] MAINTAINERS: add and claim reorder Sergio Gonzalez Monroy
2015-02-18 15:52 ` [dpdk-dev] [PATCH v5 0/6] New Reorder Library Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150208135833.GC12309@neilslaptop.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).