From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com
 [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 351052C7A
 for <dev@dpdk.org>; Mon,  9 Feb 2015 23:55:14 +0100 (CET)
Received: by pdno5 with SMTP id o5so12193852pdn.8
 for <dev@dpdk.org>; Mon, 09 Feb 2015 14:55:13 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=i1P/4vUvtYL0YDOuD4GDqS/8l7SRuh9IhOEKt3U4Wx4=;
 b=Zzn8ctMdDI8wWkFfChZTJeslHs2iPILqskP4cJyoX4z+WGJTLr0tSvgYHrdc4s7bIx
 PrzKY1uhmG+Lb8UzSCPTaTR2yzjniAZy34CyFINoTxxDS/a1WIgvFf3aBJ8UvSONNC19
 KFBkS8GcSTjwEfxxZJdSGiA1oMBN+EFWhnagMEadShT83akV2erHJojq+jBpwx7BcAt4
 SxBg5YUK/Vg+eqoEdY8aDLTlVUvaxolWT3z49/QxKe+1REeh3reDTxpyFVeJWeuSk2UQ
 XAYU0LQjRAIMJLtLfrx6oaQQG3xYoeNDXTXOdB7gDuwvSxz08mIjinDyixUELixdSoSd
 tbFg==
X-Gm-Message-State: ALoCoQn7BdAYDQHt6gkBT0ILc8xECscOLK9BQdbb7VzOE40YEDG8dx1VDbfaxHOVYJ3hjv7rxcV6
X-Received: by 10.68.98.98 with SMTP id eh2mr32855114pbb.112.1423522513536;
 Mon, 09 Feb 2015 14:55:13 -0800 (PST)
Received: from uryu.home.lan ([144.49.132.22])
 by mx.google.com with ESMTPSA id ul5sm17501275pab.36.2015.02.09.14.55.12
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 09 Feb 2015 14:55:13 -0800 (PST)
Date: Mon, 9 Feb 2015 14:55:09 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Message-ID: <20150209145509.1b7bea9b@uryu.home.lan>
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126323097BA@IRSMSX108.ger.corp.intel.com>
References: <1423116841-19799-4-git-send-email-stephen@networkplumber.org>
 <3EB4FA525960D640B5BDFFD6A3D89126323097BA@IRSMSX108.ger.corp.intel.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics
 when	read
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Feb 2015 22:55:14 -0000

On Mon, 9 Feb 2015 22:48:36 +0000
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> wrote:

> Hi Stephen,
> 
> What is the reason not to clear statistics on read? Do you have a use-case / justification for it?
> 
> (BTW, I see you added the reset functions, but was it also your intention to remove the memset to 0 from the stats read functions? :) )
> 
> Regards,
> Cristian

Read and clear is a non-standard model. Interface statistics are not read/clear.
We have lots of scripts that read statistics. Users don't like it if when 
stastics disappear.