DPDK patches and discussions
 help / color / mirror / Atom feed
From: Patrick Lu <patrick.lu@intel.com>
To: Cunming Liang <cunming.liang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] ixgbe: fix link issue in loopback mode
Date: Mon, 9 Feb 2015 08:52:25 -0700	[thread overview]
Message-ID: <20150209155225.GB18872@debian-x64.ch.intel.com> (raw)
In-Reply-To: <1423125918-31757-1-git-send-email-cunming.liang@intel.com>

On Thu, Feb 05, 2015 at 04:45:18PM +0800, Cunming Liang wrote:
> In loopback mode, it's expected force link up even when there's no cable connect.
> But in codes, setup_sfp() rewrites the related register.
> It causes in the case 'multispeed_fiber', it can't link up without cable connect. 
> 
> Signed-off-by: Cunming Liang <cunming.liang@intel.com>
> ---
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> index b341dd0..d6d408e 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> @@ -1501,6 +1501,11 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
>  		goto error;
>  	}
>  
> +	/* Skip link setup if loopback mode is enabled for 82599. */
> +	if (hw->mac.type == ixgbe_mac_82599EB &&
> +			dev->data->dev_conf.lpbk_mode == IXGBE_LPBK_82599_TX_RX)
> +		goto skip_link_setup;
> +
>  	if (ixgbe_is_sfp(hw) && hw->phy.multispeed_fiber) {
>  		err = hw->mac.ops.setup_sfp(hw);
>  		if (err)
> @@ -1510,11 +1515,6 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
>  	/* Turn on the laser */
>  	ixgbe_enable_tx_laser(hw);
>  
> -	/* Skip link setup if loopback mode is enabled for 82599. */
> -	if (hw->mac.type == ixgbe_mac_82599EB &&
> -			dev->data->dev_conf.lpbk_mode == IXGBE_LPBK_82599_TX_RX)
> -		goto skip_link_setup;
> -
>  	err = ixgbe_check_link(hw, &speed, &link_up, 0);
>  	if (err)
>  		goto error;
> -- 
> 1.8.1.4
> 
Acked-by: Patrick Lu <patrick.lu@intel.com>

  reply	other threads:[~2015-02-09 16:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05  8:45 Cunming Liang
2015-02-09 15:52 ` Patrick Lu [this message]
2015-02-15 16:10   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150209155225.GB18872@debian-x64.ch.intel.com \
    --to=patrick.lu@intel.com \
    --cc=cunming.liang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).