DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 5/7] vmxnet3: get rid of DEBUG ifdefs
Date: Tue, 10 Feb 2015 18:18:22 -0800	[thread overview]
Message-ID: <20150210181822.11456a73@uryu.home.lan> (raw)
In-Reply-To: <D0FFDD6B.34A9C%yongwang@vmware.com>

On Wed, 11 Feb 2015 00:54:57 +0000
Yong Wang <yongwang@vmware.com> wrote:

> Why not
> #define VMXNET_ASSERT(x) do { (void)(0); } while (0)
> 
> or simply
> #define VMXNET_ASSERT(x)

Because that will generate unused warnings in Gcc,
and by having the compiler evaluate the result it also makes
sure that junk doesn't get put in.

  reply	other threads:[~2015-02-11  2:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17  5:13 [dpdk-dev] [PATCH 0/7] vmxnet3: driver enhancements Stephen Hemminger
2014-12-17  5:13 ` [dpdk-dev] [PATCH 1/7] vmxnet3: add support for VLAN filtering Stephen Hemminger
2015-02-12 18:40   ` Yong Wang
2014-12-17  5:13 ` [dpdk-dev] [PATCH 2/7] vmxnet3: remove mtu check Stephen Hemminger
2015-02-11  0:54   ` Yong Wang
2014-12-17  5:13 ` [dpdk-dev] [PATCH 3/7] vmxnet3: add support for mulit-segment transmit Stephen Hemminger
2015-02-11 21:15   ` Yong Wang
2014-12-17  5:13 ` [dpdk-dev] [PATCH 4/7] vmxnet3: fix link state handling Stephen Hemminger
2015-02-11  2:24   ` Yong Wang
2014-12-17  5:13 ` [dpdk-dev] [PATCH 5/7] vmxnet3: get rid of DEBUG ifdefs Stephen Hemminger
2015-02-11  0:54   ` Yong Wang
2015-02-11  2:18     ` Stephen Hemminger [this message]
2014-12-17  5:13 ` [dpdk-dev] [PATCH 6/7] vmxnet3: support RSS and refactor offload Stephen Hemminger
2015-02-11  1:28   ` Yong Wang
2014-12-17  5:13 ` [dpdk-dev] [PATCH 7/7] vmxnet3: support jumbo frames Stephen Hemminger
2015-01-15 11:02 ` [dpdk-dev] [PATCH 0/7] vmxnet3: driver enhancements Thomas Monjalon
     [not found]   ` <20150121164925.10d1751c@urahara>
2015-01-22  9:42     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150210181822.11456a73@uryu.home.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=shemming@brocade.com \
    --cc=yongwang@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).