From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 01357B437 for ; Fri, 13 Feb 2015 11:17:37 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 13 Feb 2015 02:17:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,570,1418112000"; d="scan'208";a="685239264" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.25]) by orsmga002.jf.intel.com with SMTP; 13 Feb 2015 02:17:35 -0800 Received: by (sSMTP sendmail emulation); Fri, 13 Feb 2015 10:17:33 +0025 Date: Fri, 13 Feb 2015 10:17:33 +0000 From: Bruce Richardson To: "Mcnamara, John" Message-ID: <20150213101732.GA13304@bricha3-MOBL3> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 10:17:38 -0000 On Fri, Feb 13, 2015 at 08:25:38AM +0000, Mcnamara, John wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stefan Puiu > > Sent: Wednesday, February 11, 2015 8:51 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h > > > > In C++11 concatenated string literals need to have a space in between. > > clang 3.4 reports this as an error (and IIRC also gcc-4.8): > > > > dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 > > requires a space between literal and identifier [-Wreserved-user-defined- > > literal] > > Hi Stefan, > > That concatenated string literal with PRI* is used in 65 files in the DPDK source. Is that the only compilation error that you got? > > John It should only be a problem in header files. The C files for DPDK source are always to be compiled up with a C compiler - only the headers get included in application C++ code. /Bruce