From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 0DEAEB4FB
 for <dev@dpdk.org>; Sat, 14 Feb 2015 20:32:09 +0100 (CET)
Received: from [67.210.173.2] (helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1YMiRh-0001V3-Mz; Sat, 14 Feb 2015 14:32:07 -0500
Date: Sat, 14 Feb 2015 14:31:59 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Message-ID: <20150214193159.GB15594@neilslaptop.think-freely.org>
References: <1423937208-2063-1-git-send-email-shemming@brocade.com>
 <1423937208-2063-4-git-send-email-shemming@brocade.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1423937208-2063-4-git-send-email-shemming@brocade.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 4/4] xen: net-front poll mode driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2015 19:32:09 -0000

On Sat, Feb 14, 2015 at 01:06:48PM -0500, Stephen Hemminger wrote:
> This driver implements DPDK driver that has the same functionality
> as net-front driver in Linux kernel.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  config/common_linuxapp                |   6 +
>  lib/Makefile                          |   1 +
>  lib/librte_eal/common/eal_private.h   |   7 +
>  lib/librte_eal/linuxapp/eal/eal.c     |   8 +
>  lib/librte_pmd_xen/Makefile           |  30 ++
>  lib/librte_pmd_xen/virt_dev.c         | 400 +++++++++++++++++++++++++
>  lib/librte_pmd_xen/virt_dev.h         |  30 ++
>  lib/librte_pmd_xen/xen_adapter_info.h |  64 ++++
>  lib/librte_pmd_xen/xen_dev.c          | 369 +++++++++++++++++++++++
>  lib/librte_pmd_xen/xen_dev.h          |  96 ++++++
>  lib/librte_pmd_xen/xen_logs.h         |  23 ++
>  lib/librte_pmd_xen/xen_rxtx.c         | 546 ++++++++++++++++++++++++++++++++++
>  lib/librte_pmd_xen/xen_rxtx.h         | 110 +++++++
>  mk/rte.app.mk                         |   4 +
>  14 files changed, 1694 insertions(+)
>  create mode 100644 lib/librte_pmd_xen/Makefile
>  create mode 100644 lib/librte_pmd_xen/virt_dev.c
>  create mode 100644 lib/librte_pmd_xen/virt_dev.h
>  create mode 100644 lib/librte_pmd_xen/xen_adapter_info.h
>  create mode 100644 lib/librte_pmd_xen/xen_dev.c
>  create mode 100644 lib/librte_pmd_xen/xen_dev.h
>  create mode 100644 lib/librte_pmd_xen/xen_logs.h
>  create mode 100644 lib/librte_pmd_xen/xen_rxtx.c
>  create mode 100644 lib/librte_pmd_xen/xen_rxtx.h
><snip>
> +
> +int
> +rte_xen_pmd_init(void)
> +{
> +	PMD_INIT_FUNC_TRACE();
> +
> +	xen_evt_fd = open("/dev/"XEN_PMD_UIO_NAME, O_RDWR);
> +
> +	if (xen_evt_fd == -1) {
> +		if (errno != ENOENT)
> +			PMD_INIT_LOG(ERR, "cannot open event device %s",
> +					"/dev/"XEN_PMD_UIO_NAME);
> +		return 0;
> +	}
> +
> +	return virt_eth_driver_register(&rte_xen_pmd);
> +}
It looks like you've created a new method of registering a pmd here?  Why not
use the existing REGISTER_PMD_DRIVER macro?  It seems like this method will
break the DSO build.

Neil

>